Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310561: JFR: Unify decodeDescriptors(String, String) #14598

Closed
wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jun 21, 2023

Could I have a review of a fix that removes duplicated code.

Testing: jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310561: JFR: Unify decodeDescriptors(String, String) (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14598/head:pull/14598
$ git checkout pull/14598

Update a local copy of the PR:
$ git checkout pull/14598
$ git pull https://git.openjdk.org/jdk.git pull/14598/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14598

View PR using the GUI difftool:
$ git pr show -t 14598

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14598.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2023

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jun 21, 2023
@egahlin egahlin marked this pull request as ready for review June 21, 2023 16:14
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310561: JFR: Unify decodeDescriptors(String, String)

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 7da3f19: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
  • 8e04702: 8242152: SA does not include StackMapTables when dumping .class files
  • 3bc475e: 8309909: remove test nsk.jvmti test objmonusage006 from ProblemList-Virtual.txt
  • 3661cde: 8309853: StructuredTaskScope.join description improvements
  • ac44ef1: 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all
  • 3be50da: 8310512: Cleanup indentation in jfc files
  • f286e5a: 8310575: no @since for StandardDoclet
  • 16a34e8: 8310384: Add hooks for custom image creation
  • 226c6a0: 8309883: no @since info in com.sun.tools.javac package-info.java, Main.java
  • fd1163d: 8310332: Fix -Wconversion warnings in MethodData
  • ... and 1 more: https://git.openjdk.org/jdk/compare/59c6c0e1b7148a7139f5e6a4ba2b19623c20c77d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 22, 2023
@egahlin
Copy link
Member Author

egahlin commented Jun 22, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

Going to push as commit 8976ebf.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 7da3f19: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
  • 8e04702: 8242152: SA does not include StackMapTables when dumping .class files
  • 3bc475e: 8309909: remove test nsk.jvmti test objmonusage006 from ProblemList-Virtual.txt
  • 3661cde: 8309853: StructuredTaskScope.join description improvements
  • ac44ef1: 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all
  • 3be50da: 8310512: Cleanup indentation in jfc files
  • f286e5a: 8310575: no @since for StandardDoclet
  • 16a34e8: 8310384: Add hooks for custom image creation
  • 226c6a0: 8309883: no @since info in com.sun.tools.javac package-info.java, Main.java
  • fd1163d: 8310332: Fix -Wconversion warnings in MethodData
  • ... and 1 more: https://git.openjdk.org/jdk/compare/59c6c0e1b7148a7139f5e6a4ba2b19623c20c77d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 22, 2023
@openjdk openjdk bot closed this Jun 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@egahlin Pushed as commit 8976ebf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants