Skip to content

8220730: sun.security.provider.SecureRandom default constructor has wrong documentation #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

bradfordwetmore
Copy link
Contributor

@bradfordwetmore bradfordwetmore commented Nov 26, 2020

This is to fix some out-of-date information in the javadoc for the SHA1PRNG that has generated a customer bug.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8220730: sun.security.provider.SecureRandom default constructor has wrong documentation

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1461/head:pull/1461
$ git checkout pull/1461

@bradfordwetmore bradfordwetmore marked this pull request as ready for review November 26, 2020 16:35
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2020

👋 Welcome back wetmore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 26, 2020
@openjdk
Copy link

openjdk bot commented Nov 26, 2020

@bradfordwetmore The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 26, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 26, 2020

Webrevs

Copy link
Contributor

@wangweij wangweij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel some sentences are still not precise.

Copy link
Contributor

@wangweij wangweij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks.

@openjdk
Copy link

openjdk bot commented Nov 26, 2020

@bradfordwetmore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8220730: sun.security.provider.SecureRandom default constructor has wrong documentation

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • 4e43b28: 8256359: AArch64: runtime/ReservedStack/ReservedStackTestCompiler.java fails
  • 6e00622: 8256488: [aarch64] Use ldpq/stpq instead of ld4/st4 for small copies in StubGenerator::copy_memory
  • a93841a: 8255277: randomDelay in DrainDeadlockT and LoggingDeadlock do not randomly delay
  • 2d30a10: 8257069: C2: Clarify and sanity test RegMask/RegMaskIterator
  • 0a5de50: 8257151: ZGC: Simplify ZVerify
  • bf66d73: 8257073: ZGC: Try forward object before retaining page
  • 1b3aa3a: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8
  • 734d3c3: 8256862: Several java/foreign tests fail on x86_32 platforms
  • 7946c94: 8257082: ZGC: Clean up ZRuntimeWorkers and ZWorkers
  • f6d6a07: 8256938: Improve remembered set sampling task scheduling
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/b52f6c053bf5cf6363088cb8bd210abb4e7350ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 26, 2020
@bradfordwetmore
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Nov 26, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 26, 2020
@openjdk
Copy link

openjdk bot commented Nov 26, 2020

@bradfordwetmore Since your change was applied there have been 52 commits pushed to the master branch:

  • 4e43b28: 8256359: AArch64: runtime/ReservedStack/ReservedStackTestCompiler.java fails
  • 6e00622: 8256488: [aarch64] Use ldpq/stpq instead of ld4/st4 for small copies in StubGenerator::copy_memory
  • a93841a: 8255277: randomDelay in DrainDeadlockT and LoggingDeadlock do not randomly delay
  • 2d30a10: 8257069: C2: Clarify and sanity test RegMask/RegMaskIterator
  • 0a5de50: 8257151: ZGC: Simplify ZVerify
  • bf66d73: 8257073: ZGC: Try forward object before retaining page
  • 1b3aa3a: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8
  • 734d3c3: 8256862: Several java/foreign tests fail on x86_32 platforms
  • 7946c94: 8257082: ZGC: Clean up ZRuntimeWorkers and ZWorkers
  • f6d6a07: 8256938: Improve remembered set sampling task scheduling
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/b52f6c053bf5cf6363088cb8bd210abb4e7350ff...master

Your commit was automatically rebased without conflicts.

Pushed as commit 62d72de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bradfordwetmore bradfordwetmore deleted the JDK-8220730 branch December 4, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants