Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309909: remove test nsk.jvmti test objmonusage006 from ProblemList-Virtual.txt #14610

Closed
wants to merge 1 commit into from

Conversation

sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented Jun 22, 2023

The following bug was closed as "Cannot Reproduce":
8300709 nsk/jvmti/GetObjectMonitorUsage/objmonusage006 test asserts with virtual thread wrapper

I was not able to reproduce the assert in thousands mach5 runs on multiple debug builds.
Also, the original sources were significantly changed, so it is not clear anymore in what context the assert was fired.
The test is problem-listed in ProblemList-Virtual.txt.

This sub-task is to unproblem-list the test:
vmTestbase/nsk/jvmti/GetObjectMonitorUsage/objmonusage006/TestDescription.java

If the original asset is reproduced again then the plan is to reopen the 8300709 and update it with the details needed for issue investigation.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309909: remove test nsk.jvmti test objmonusage006 from ProblemList-Virtual.txt (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14610/head:pull/14610
$ git checkout pull/14610

Update a local copy of the PR:
$ git checkout pull/14610
$ git pull https://git.openjdk.org/jdk.git pull/14610/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14610

View PR using the GUI difftool:
$ git pr show -t 14610

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14610.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2023

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@sspitsyn To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and trivial.

@plummercj
Copy link
Contributor

/label serviceability

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309909: remove test nsk.jvmti test objmonusage006 from ProblemList-Virtual.txt

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 73 new commits pushed to the master branch:

  • 3661cde: 8309853: StructuredTaskScope.join description improvements
  • ac44ef1: 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all
  • 3be50da: 8310512: Cleanup indentation in jfc files
  • f286e5a: 8310575: no @since for StandardDoclet
  • 16a34e8: 8310384: Add hooks for custom image creation
  • 226c6a0: 8309883: no @since info in com.sun.tools.javac package-info.java, Main.java
  • fd1163d: 8310332: Fix -Wconversion warnings in MethodData
  • 72501cf: 8310379: Relax prerequisites for java.base-jmod target
  • 59c6c0e: 8310335: JFR: Modernize collections and switch statements
  • 826dcb5: 8264899: C1: -XX:AbortVMOnException does not work if all methods in the call stack are compiled with C1 and there are no exception handlers
  • ... and 63 more: https://git.openjdk.org/jdk/compare/353e581a53c5c16a8d8b824464d7ca4854d3422f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated serviceability serviceability-dev@openjdk.org labels Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@plummercj
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 22, 2023

Webrevs

@sspitsyn
Copy link
Contributor Author

Thank you for review, Chris.

@sspitsyn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

Going to push as commit 3bc475e.
Since your change was applied there have been 73 commits pushed to the master branch:

  • 3661cde: 8309853: StructuredTaskScope.join description improvements
  • ac44ef1: 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all
  • 3be50da: 8310512: Cleanup indentation in jfc files
  • f286e5a: 8310575: no @since for StandardDoclet
  • 16a34e8: 8310384: Add hooks for custom image creation
  • 226c6a0: 8309883: no @since info in com.sun.tools.javac package-info.java, Main.java
  • fd1163d: 8310332: Fix -Wconversion warnings in MethodData
  • 72501cf: 8310379: Relax prerequisites for java.base-jmod target
  • 59c6c0e: 8310335: JFR: Modernize collections and switch statements
  • 826dcb5: 8264899: C1: -XX:AbortVMOnException does not work if all methods in the call stack are compiled with C1 and there are no exception handlers
  • ... and 63 more: https://git.openjdk.org/jdk/compare/353e581a53c5c16a8d8b824464d7ca4854d3422f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 22, 2023
@openjdk openjdk bot closed this Jun 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@sspitsyn Pushed as commit 3bc475e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sspitsyn sspitsyn deleted the b0 branch June 22, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants