8222329: Readable read(CharBuffer) does not specify that 0 is returned when there is no remaining space in buffer

[bplb]

Clarify the behavior of java.lang.Readable when the specified java.nio.CharBuffer parameter is empty but read-only, and when it is full.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8310677 to be approved

Issues

• JDK-8222329: Readable read(CharBuffer) does not specify that 0 is returned when there is no remaining space in buffer (Enhancement - P3)
• JDK-8310677: Readable read(CharBuffer) does not specify that 0 is returned when there is no remaining space in buffer (CSR)

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer) ⚠️ Review applies to 8bcf4674
• Lance Andersen (@LanceAndersen - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14616/head:pull/14616
$ git checkout pull/14616

Update a local copy of the PR:
$ git checkout pull/14616
$ git pull https://git.openjdk.org/jdk.git pull/14616/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14616

View PR using the GUI difftool:
$ git pr show -t 14616

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14616.diff

Webrev

Link to Webrev Comment

[bplb]

/csr

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@bplb please create a CSR request for issue JDK-8222329 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@bplb The following labels will be automatically applied to this pull request:

• core-libs
• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 07: Full - Incremental (12f982b0)
• 06: Full - Incremental (8bcf4674)
• 05: Full - Incremental (7281b482)
• 04: Full - Incremental (94505a45)
• 03: Full - Incremental (d693c612)
• 02: Full - Incremental (055107bd)
• 01: Full - Incremental (ef650028)
• 00: Full (0fb2bf1f)

[bplb]

CSR will be filed if consensus is reached here.

[RogerRiggs]

Looks good.

[RogerRiggs]

Looks good but for one typo.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8222329: Readable read(CharBuffer) does not specify that 0 is returned when there is no remaining space in buffer

Reviewed-by: rriggs, lancea, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• a08352f: 8305671: javac rejects semicolons in compilation units with no imports
• ff9a754: 8310459: [BACKOUT] 8304450: [vectorapi] Refactor VectorShuffle implementation
• 815ac6e: 8310907: Add missing file
• 289f218: 8310861: Improve location reporting for javac serial lint warnings
• d32eb01: 8310682: No package-info (and @SInCE) for package jdk.nio.mapmode
• e624484: 8308540: On Kerberos TGT referral, if krb5.conf is missing realm, bad exception message
• 5ff42d1: 8303549: [AIX] TestNativeStack.java is failing with exit value 1
• 24abd10: 8310192: RISC-V: Merge vector min & max instructs with similar match rules
• 3357867: 8310276: RISC-V: Make use of shadd macro-assembler function when possible
• c1c5bd0: 8310541: G1: Remove redundant check in G1Policy::need_to_start_conc_mark
• ... and 28 more: https://git.openjdk.org/jdk/compare/0e4fde3d300b91e6f93fe4d602f99251c75aa847...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit 58bb655.
Since your change was applied there have been 52 commits pushed to the master branch:

• 05e9c41: 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests
• 1587836: 8310425: [JVMCI] compiler/runtime/TestConstantDynamic: lookupConstant returned an object of incorrect type: null
• 73d7aa1: 8301489: C1: ShortLoopOptimizer might lift instructions before their inputs
• 990e3a7: 8308899: Introduce Classfile context and improve Classfile options
• 79c056e: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen
• 45b581b: 8309583: AArch64: Optimize firstTrue() when amount of elements < 8
• 87e6fab: 8310873: Re-enable locked_create_entry symbol check in runtime/NMT/CheckForProperDetailStackTrace.java for RISC-V
• 39fa4e6: 8310489: New test runtime/ClassInitErrors/TestStackOverflowDuringInit.java failed
• 46add3f: 8310909: java.io.InvalidObjectException has redundant @since tag
• 8f5b677: 8310908: Non-standard @since tag in com.sun.java.accessibility.util.package-info
• ... and 42 more: https://git.openjdk.org/jdk/compare/0e4fde3d300b91e6f93fe4d602f99251c75aa847...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 58bb655.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.