Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310606: Fix signed integer overflow, part 3 #14619

Closed
wants to merge 6 commits into from

Conversation

dean-long
Copy link
Member

@dean-long dean-long commented Jun 22, 2023

Most of these changes are straight-forward, but these could use some explaining:

AllocatePrefetchDistance was accessed before it's dynamic constraint function got run. I changed it to use static constraints.

RangeCheckEliminator::update_bound(): for constant bounds with meaningless values, bail out. For X + c bounds, use Java wrap-around semantics.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310606: Fix signed integer overflow, part 3 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14619/head:pull/14619
$ git checkout pull/14619

Update a local copy of the PR:
$ git checkout pull/14619
$ git pull https://git.openjdk.org/jdk.git pull/14619/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14619

View PR using the GUI difftool:
$ git pr show -t 14619

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14619.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2023

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@dean-long The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 22, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2023

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@dean-long This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310606: Fix signed integer overflow, part 3

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • dad7bd9: 8310234: Refactor Locale tests to use JUnit
  • 69f3114: 8310676: add note about unnamed module to Elements.getAllModuleElements
  • bfcca5e: 8310494: Do not include constantPool.hpp from instanceKlass.hpp
  • 0314292: 8310267: Javadoc for Class#isPrimitive() is incorrect regarding Class objects for primitives
  • a9c0a0f: 8310628: GcInfoBuilder.c missing JNI Exception checks
  • 556831d: 8310460: Remove jdeps -profile option
  • d91d0d3: 8310537: Fix -Wconversion warnings in gcUtil.hpp
  • 7628da2: 8279254: PKCS9Attribute SigningTime always encoded in UTFTime
  • 5ca4cdd: 8309740: Expand timeout windows for tests in JDK-8179502
  • e78fd46: 8310735: Build failure after JDK-8310577 with GCC8
  • ... and 19 more: https://git.openjdk.org/jdk/compare/16a34e8e1e603d2cc8f05fcf01376230af441dbd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 23, 2023
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dean-long
Copy link
Member Author

Thanks Vladimir, Tobias, and Andrew.

@dean-long
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2023

Going to push as commit da0f832.
Since your change was applied there have been 96 commits pushed to the master branch:

  • f0c2f09: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected.
  • 9f46fc2: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files.
  • 7fffdb5: 8310405: Linker.Option.firstVariadicArg should specify which index values are valid
  • b6c789f: 8309140: ResourceHashtable failed "assert(~(_allocation_t[0] | allocation_mask) == (uintptr_t)this) failed: lost resource object"
  • 9f98136: 6956385: URLConnection.getLastModified() leaks file handles for jar:file and file: URLs
  • 46e4ee1: 8310974: NMT: Arena diffs miss the scale
  • f17bfee: 8311034: Fix typo in javac man page
  • 2ccdd29: 8299825: Move StdoutLog and StderrLog to LogConfiguration
  • e3f18af: 8311007: jdk/jfr/tool/TestView.java can't find event
  • 08c51f2: 8310920: Fix -Wconversion warnings in command line flags
  • ... and 86 more: https://git.openjdk.org/jdk/compare/16a34e8e1e603d2cc8f05fcf01376230af441dbd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 28, 2023
@openjdk openjdk bot closed this Jun 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 28, 2023
@openjdk
Copy link

openjdk bot commented Jun 28, 2023

@dean-long Pushed as commit da0f832.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
4 participants