JDK-8310066: Improve test coverage for JVMTI GetThreadState on carrier and mounted vthread

[alexmenkov]

This is follow-up JDK-8307153/JDK-8309612 (JVMTI GetThreadState on carrier should return STATE_WAITING)
New test tests GetThreadState for different thread states.
The test detected a bug in the implementation, new issue is created: JDK-8310584
Corresponding testcases are commented now in the test, fix for JDK-8310584 will uncomment them

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310066: Improve test coverage for JVMTI GetThreadState on carrier and mounted vthread (Enhancement - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer) ⚠️ Review applies to 8918411b
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14622/head:pull/14622
$ git checkout pull/14622

Update a local copy of the PR:
$ git checkout pull/14622
$ git pull https://git.openjdk.org/jdk.git pull/14622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14622

View PR using the GUI difftool:
$ git pr show -t 14622

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14622.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (d9898865)
• 04: Full - Incremental (04cec709)
• 03: Full - Incremental (8918411b)
• 02: Full - Incremental (6c517cef)
• 01: Full - Incremental (b5b39bcd)
• 00: Full (c5f669b7)

[sspitsyn]

The test is great.
I realize it is not easy to make it fully reliable though.
So, will need another pass.

[alexmenkov]

The test is great. I realize it is not easy to make it fully reliable though. So, will need another pass.

Good point about spurious wakeups.
Updated the test to handle them.
Now for WAITING scenarios the test suspends test thread and ensures it's waiting. While the thread is suspended (either carrier or virtual) we can safely verify thread states

[sspitsyn]

Thank you for the test. It is nice to have it.
It looks good.
Thanks,
Serguei

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310066: Improve test coverage for JVMTI GetThreadState on carrier and mounted vthread

Reviewed-by: sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 329 new commits pushed to the master branch:

• 4b1403d: 8311548: AArch64: [ZGC] Many tests fail with "assert(allocates2(pc)) failed: not in CodeBuffer memory" on some CPUs
• 940a4e1: 8304503: Modernize debugging jvm args in demo netbeans projects
• 57e7e82: 8309637: runtime/handshake/HandshakeTimeoutTest.java fails with "has not cleared handshake op" and SIGILL
• 63f32fb: 8311528: Remove IDE specific SuppressWarnings
• b285ed7: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
• 6569b25: 8311593: Minor doc issue in MemorySegment::copy
• 623cfcd: 8310892: ScopedValue throwing StructureViolationException should be clearer
• 06a1a15: 8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly
• 581f90e: 8311604: Simplify NOCOOPS requested addresses for archived heap objects
• 4a1fcb6: 8193513: add support for printing a stack trace on class loading
• ... and 319 more: https://git.openjdk.org/jdk/compare/45414fc2dfa41cbbfc6de7fec15eb47f41cf8986...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexmenkov]

Ping. need one more reviewer

[plummercj]

Just a couple of comment suggestions. Otherwise looks good.

What testing did you do? Any -Xcomp testing?

[alexmenkov]

What testing did you do? Any -Xcomp testing?

Just run with -Xcomp on all mach5 platforms, passed

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 15195e6.
Since your change was applied there have been 337 commits pushed to the master branch:

• 6cb9ec3: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality
• 401c3de: 8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990
• e154b0d: 8311606: Change read_icc_profile() to static function in java.desktop/share/native/libjavajpeg/imageioJPEG.c
• a03a3a4: 8311178: JMH tests don't scale well when sharing output buffers
• 00c7f91: 8310047: Add UTF-32 based Charsets into StandardCharsets
• caadad4: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
• b3f3403: 8311689: Wrong visible amount in Adjustable of ScrollPane
• a1cfc96: 8311245: JFR: Remove t.printStackTrace() in PeriodicEvents
• 4b1403d: 8311548: AArch64: [ZGC] Many tests fail with "assert(allocates2(pc)) failed: not in CodeBuffer memory" on some CPUs
• 940a4e1: 8304503: Modernize debugging jvm args in demo netbeans projects
• ... and 327 more: https://git.openjdk.org/jdk/compare/45414fc2dfa41cbbfc6de7fec15eb47f41cf8986...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 15195e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.