8310735: Build failure after JDK-8310577 with GCC8

[DamonFool]

Since enum BasicType had been changed to enum BasicType : u1, basic_type >= 0 would be always true.
So it's safe to remove such conditions in these asserts.
Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310735: Build failure after JDK-8310577 with GCC8 (Bug - P3)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14627/head:pull/14627
$ git checkout pull/14627

Update a local copy of the PR:
$ git checkout pull/14627
$ git pull https://git.openjdk.org/jdk.git pull/14627/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14627

View PR using the GUI difftool:
$ git pr show -t 14627

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14627.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (87b4a7ec)

[RealLucy]

Changes look good and obviously do fix the build failure.
Thanks for taking care.

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310735: Build failure after JDK-8310577 with GCC8

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonFool]

Changes look good and obviously do fix the build failure. Thanks for taking care.

Thanks @RealLucy for your quick review.

Do you think it's trivial?

[RealLucy]

Do you think it's trivial?

I would guess so. Go ahead and integrate.

[DamonFool]

I would guess so. Go ahead and integrate.

Thanks @RealLucy .
/integrate

[openjdk]

Going to push as commit e78fd46.

[openjdk]

@DamonFool Pushed as commit e78fd46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[coleenp]

Thanks for fixing this.