8310459: [BACKOUT] 8304450: [vectorapi] Refactor VectorShuffle implementation

[jatin-bhateja]

Backing out shuffle related overhaul done with JDK-8304450, we saw significant performance degradation in VectorAPI JMH micros and some of our internal benchmarks. Following two issues were filed on this recently.

1/ JDK-8310459: Performance drop in VectorAPI slice / unslice performance w.r.t to JDK-20.
2/ JDK-8309373: Performance drop in Vector-API based kernel with JDK-21.

A follow-up JBS JDK-8310691 is created to address this in JDK-22.

Best Regards,
Jatin

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310459: [BACKOUT] 8304450: [vectorapi] Refactor VectorShuffle implementation (Sub-task - P3)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Sandhya Viswanathan (@sviswa7 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14629/head:pull/14629
$ git checkout pull/14629

Update a local copy of the PR:
$ git checkout pull/14629
$ git pull https://git.openjdk.org/jdk.git pull/14629/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14629

View PR using the GUI difftool:
$ git pr show -t 14629

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14629.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jatin-bhateja The following labels will be automatically applied to this pull request:

• core-libs
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[jatin-bhateja]

/label add hotspot-compiler-dev

[openjdk]

@jatin-bhateja
The hotspot-compiler label was successfully added.

[mlbridge]

Webrevs

• 00: Full (cb4a075a)

[TobiHartmann]

Looks good to me.

[openjdk]

@jatin-bhateja This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310459: [BACKOUT] 8304450: [vectorapi] Refactor VectorShuffle implementation

Reviewed-by: thartmann, sviswanathan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

• 289f218: 8310861: Improve location reporting for javac serial lint warnings
• d32eb01: 8310682: No package-info (and @SInCE) for package jdk.nio.mapmode
• e624484: 8308540: On Kerberos TGT referral, if krb5.conf is missing realm, bad exception message
• 5ff42d1: 8303549: [AIX] TestNativeStack.java is failing with exit value 1
• 24abd10: 8310192: RISC-V: Merge vector min & max instructs with similar match rules
• 3357867: 8310276: RISC-V: Make use of shadd macro-assembler function when possible
• c1c5bd0: 8310541: G1: Remove redundant check in G1Policy::need_to_start_conc_mark
• 5271f4d: 8310354: G1: Annotate G1MMUTracker::when_sec with const
• a420ff4: 6664309: Docking point of a floating toolbar changes after closing
• a96e92c: 8310816: GcInfoBuilder float/double signature mismatch
• ... and 23 more: https://git.openjdk.org/jdk/compare/5a82fa3bb278b5b80b9ede0619f364fe13cdbede...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jatin-bhateja]

/integrate

[openjdk]

Going to push as commit ff9a754.
Since your change was applied there have been 34 commits pushed to the master branch:

• 815ac6e: 8310907: Add missing file
• 289f218: 8310861: Improve location reporting for javac serial lint warnings
• d32eb01: 8310682: No package-info (and @SInCE) for package jdk.nio.mapmode
• e624484: 8308540: On Kerberos TGT referral, if krb5.conf is missing realm, bad exception message
• 5ff42d1: 8303549: [AIX] TestNativeStack.java is failing with exit value 1
• 24abd10: 8310192: RISC-V: Merge vector min & max instructs with similar match rules
• 3357867: 8310276: RISC-V: Make use of shadd macro-assembler function when possible
• c1c5bd0: 8310541: G1: Remove redundant check in G1Policy::need_to_start_conc_mark
• 5271f4d: 8310354: G1: Annotate G1MMUTracker::when_sec with const
• a420ff4: 6664309: Docking point of a floating toolbar changes after closing
• ... and 24 more: https://git.openjdk.org/jdk/compare/5a82fa3bb278b5b80b9ede0619f364fe13cdbede...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jatin-bhateja Pushed as commit ff9a754.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.