Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8170432: Class java.util.UUID & @Override #1463

Closed
wants to merge 1 commit into from

Conversation

@Fleshgrinder
Copy link
Contributor

@Fleshgrinder Fleshgrinder commented Nov 26, 2020

Adds @Override annotation to all methods in java.util.UUID that implement methods from the implemented interfaces.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux additional Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (8/8 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test task

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1463/head:pull/1463
$ git checkout pull/1463

Adds `@Override` annotation to all methods in `java.util.UUID` that implement methods from the implemented interfaces.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 26, 2020

👋 Welcome back Fleshgrinder! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Nov 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

@Fleshgrinder The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Nov 26, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 26, 2020

Webrevs

Loading

dfuch
dfuch approved these changes Nov 26, 2020
Copy link
Member

@dfuch dfuch left a comment

Hi,

This looks reasonable to me.

best regards,

-- daniel

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

⚠️ @Fleshgrinder the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8170432
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

@Fleshgrinder This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8170432: Class java.util.UUID & @Override

Reviewed-by: dfuchs, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 5be4de8: 8245058: improve presentation of annotations for modules and packages
  • d51e2ab: 8256986: [PPC64] C2 crashes when accessing nonexisting jvms of CallLeafDirectNode
  • 644271e: 8248566: Make API docs more usable on mobile browsers
  • 53d1444: 8244535: JavaDoc search is overly strict with letter case
  • 78fdb65: 8254893: Fix display of search tag results without holder information
  • 20525d2: 8257149: Improve G1 Service thread task scheduling to guarantee task delay
  • f2f3ba9: 8242652: Throw SkippedException if no JS engine availabe in TestSearchScript
  • ee99686: 8252645: Change time measurements in G1ServiceThread to only account remembered set work
  • a3eec39: 8257181: s390x builds are very noisy with gc-sections messages
  • 9a468d8: 8256757: Incorrect MachCallRuntimeNode::ret_addr_offset() for CallLeafNoFP on x86_32
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/6e0062236c836b261cde5792963fb9de3068b8f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @LanceAndersen) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Nov 26, 2020
@Fleshgrinder
Copy link
Contributor Author

@Fleshgrinder Fleshgrinder commented Nov 26, 2020

/integrate

Loading

@openjdk openjdk bot added the sponsor label Nov 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

@Fleshgrinder
Your change (at version c7c18fe) is now ready to be sponsored by a Committer.

Loading

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Looks fine. It appears you need a sponsor so I can do that once you integrate

Loading

@LanceAndersen
Copy link
Contributor

@LanceAndersen LanceAndersen commented Nov 27, 2020

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

@LanceAndersen @Fleshgrinder Since your change was applied there have been 13 commits pushed to the master branch:

  • 5be4de8: 8245058: improve presentation of annotations for modules and packages
  • d51e2ab: 8256986: [PPC64] C2 crashes when accessing nonexisting jvms of CallLeafDirectNode
  • 644271e: 8248566: Make API docs more usable on mobile browsers
  • 53d1444: 8244535: JavaDoc search is overly strict with letter case
  • 78fdb65: 8254893: Fix display of search tag results without holder information
  • 20525d2: 8257149: Improve G1 Service thread task scheduling to guarantee task delay
  • f2f3ba9: 8242652: Throw SkippedException if no JS engine availabe in TestSearchScript
  • ee99686: 8252645: Change time measurements in G1ServiceThread to only account remembered set work
  • a3eec39: 8257181: s390x builds are very noisy with gc-sections messages
  • 9a468d8: 8256757: Incorrect MachCallRuntimeNode::ret_addr_offset() for CallLeafNoFP on x86_32
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/6e0062236c836b261cde5792963fb9de3068b8f7...master

Your commit was automatically rebased without conflicts.

Pushed as commit b4cba15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants