Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310585: GetThreadState spec mentions undefined JVMTI_THREAD_STATE_MONITOR_WAITING #14634

Closed
wants to merge 1 commit into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Jun 23, 2023

Trivial fix in JVMTI spec.
As it's just a typo, CSR is not required


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310585: GetThreadState spec mentions undefined JVMTI_THREAD_STATE_MONITOR_WAITING (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14634/head:pull/14634
$ git checkout pull/14634

Update a local copy of the PR:
$ git checkout pull/14634
$ git pull https://git.openjdk.org/jdk.git pull/14634/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14634

View PR using the GUI difftool:
$ git pr show -t 14634

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14634.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2023

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@alexmenkov The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Jun 23, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 23, 2023

Webrevs

@liach liach mentioned this pull request Jun 24, 2023
3 tasks
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Looks good.
Thanks,
Serguei

@openjdk
Copy link

openjdk bot commented Jun 24, 2023

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310585: GetThreadState spec mentions undefined JVMTI_THREAD_STATE_MONITOR_WAITING

Reviewed-by: sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 179 new commits pushed to the master branch:

  • 815ac6e: 8310907: Add missing file
  • 289f218: 8310861: Improve location reporting for javac serial lint warnings
  • d32eb01: 8310682: No package-info (and @SInCE) for package jdk.nio.mapmode
  • e624484: 8308540: On Kerberos TGT referral, if krb5.conf is missing realm, bad exception message
  • 5ff42d1: 8303549: [AIX] TestNativeStack.java is failing with exit value 1
  • 24abd10: 8310192: RISC-V: Merge vector min & max instructs with similar match rules
  • 3357867: 8310276: RISC-V: Make use of shadd macro-assembler function when possible
  • c1c5bd0: 8310541: G1: Remove redundant check in G1Policy::need_to_start_conc_mark
  • 5271f4d: 8310354: G1: Annotate G1MMUTracker::when_sec with const
  • a420ff4: 6664309: Docking point of a floating toolbar changes after closing
  • ... and 169 more: https://git.openjdk.org/jdk/compare/45414fc2dfa41cbbfc6de7fec15eb47f41cf8986...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 24, 2023
@alexmenkov
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2023

Going to push as commit a97f98f.
Since your change was applied there have been 206 commits pushed to the master branch:

  • 2cf5c2f: 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails
  • 269852b: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x
  • 4bce38c: 8310830: typo in the parameter name in @throws of ClassDesc::ofDescriptor
  • 315242b: 8310975: java.util.FormatItemModifier should not be protected
  • d6dd0dc: 8308452: Extend internal Architecture enum with byte order and address size
  • fb283df: 8310828: java.sql java.sql.rowset packages have no @since info
  • ec45bd6: 8310182: DateTimeFormatter date formats (ISO_LOCAL_DATE) separated with hyphen, not dash
  • 2bd4136: 8310849: Pattern matching for instanceof and arrayType cleanup in j.l.invoke and j.l.reflect
  • 7ce967a: 8281455: Change JVM options with small ranges from 64 to 32 bits, for gc_globals.hpp
  • f6133ed: 8310890: Normalize identifier names
  • ... and 196 more: https://git.openjdk.org/jdk/compare/45414fc2dfa41cbbfc6de7fec15eb47f41cf8986...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2023
@openjdk openjdk bot closed this Jun 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2023
@openjdk
Copy link

openjdk bot commented Jun 27, 2023

@alexmenkov Pushed as commit a97f98f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the jvmti_spec branch June 27, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants