Skip to content

8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit #14641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit #14641

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fafc0aa
resolve VMSupport at bootstrap to avoid nested exception in Exception…
dougxc Jun 25, 2023
614e1e9
try harder to show nested exception during exception translation
dougxc Jun 26, 2023
819a24f
each exception translation failure should trigger a JVMCI event
dougxc Jun 26, 2023
734903a
revert to lazy loading of VMSupport
dougxc Jun 27, 2023
9236128
[skip ci] handle pending HotSpot exception closer to site causing exc…
dougxc Jun 28, 2023
e46a6a1
[skip ci] Merge remote-tracking branch 'openjdk-jdk/master' into JDK-…
dougxc Jun 29, 2023
5bb3b52
fix warning about conversion from size_t to int
dougxc Jun 30, 2023
11a2dad
fix warning about conversion from size_t to int - take 2
dougxc Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/hotspot/share/jvmci/jvmciEnv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ class ExceptionTranslation: public StackObj {
ResourceMark rm;
jlong buffer = (jlong) NEW_RESOURCE_ARRAY_IN_THREAD_RETURN_NULL(THREAD, jbyte, buffer_size);
if (buffer == 0L) {
JVMCI_event_1("error translating exception: translation buffer allocation failed");
decode(THREAD, vmSupport, -1, 0L);
return;
}
Expand All @@ -403,13 +404,15 @@ class ExceptionTranslation: public StackObj {
// Cannot get name of exception thrown by `encode` as that involves
// calling into libjvmci which in turn can raise another exception.
_from_env->clear_pending_exception();
JVMCI_event_1("error translating exception: unknown error");
decode(THREAD, vmSupport, -3, 0L);
return;
} else if (HAS_PENDING_EXCEPTION) {
Handle throwable = Handle(THREAD, PENDING_EXCEPTION);
Symbol *ex_name = throwable->klass()->name();
CLEAR_PENDING_EXCEPTION;
if (ex_name == vmSymbols::java_lang_OutOfMemoryError()) {
JVMCI_event_1("error translating exception: OutOfMemoryError");
decode(THREAD, vmSupport, -2, 0L);
} else {
char* char_buffer = (char*) buffer + 4;
Expand Down
2 changes: 1 addition & 1 deletion src/java.base/share/classes/jdk/internal/vm/VMSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public static void decodeAndThrowThrowable(int format, long buffer, boolean inJV
String context = String.format("while encoding an exception to translate it %s the JVM heap",
inJVMHeap ? "to" : "from");
if (format == -1) {
throw new InternalError("native errorOrBuffer could not be allocated " + context);
throw new InternalError("native buffer could not be allocated " + context);
}
if (format == -2L) {
throw new OutOfMemoryError("OutOfMemoryError occurred " + context);
Expand Down