Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. #14647

Closed
wants to merge 1 commit into from

Conversation

sid8606
Copy link
Member

@sid8606 sid8606 commented Jun 26, 2023

Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch, it leads to assert(is_valid()) failed: invalid register.

Ran tier1 test cases passing with release, fastdebug and slowdebug.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14647/head:pull/14647
$ git checkout pull/14647

Update a local copy of the PR:
$ git checkout pull/14647
$ git pull https://git.openjdk.org/jdk.git pull/14647/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14647

View PR using the GUI difftool:
$ git pr show -t 14647

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14647.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2023

👋 Welcome back sid8606! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 26, 2023
@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@sid8606 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 26, 2023
@sid8606 sid8606 changed the title 8309889: Missing return statement after calling jump_to_native_invoke… 8309889: [s390] Missing return statement after calling jump_to_native_invoker mrthod in generate_method_handle_dispatch. Jun 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 26, 2023

Webrevs

@sid8606
Copy link
Member Author

sid8606 commented Jun 28, 2023

@RealLucy @TheRealMDoerr
Please review this PR as per your availability.
Thank you

Copy link
Member

@offamitkumar offamitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and test passed, Thanks for keeping it short.

I have changed mrthod to method in title. Probably you want to do the same in our ZenHub.

@offamitkumar
Copy link
Member

/issue add 8309889

@openjdk
Copy link

openjdk bot commented Jun 28, 2023

@offamitkumar Only the author (@sid8606) is allowed to issue the /issue command.

@sid8606
Copy link
Member Author

sid8606 commented Jun 28, 2023

/issue add 8309889

@openjdk openjdk bot changed the title 8309889: [s390] Missing return statement after calling jump_to_native_invoker mrthod in generate_method_handle_dispatch. 8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. Jun 28, 2023
@openjdk
Copy link

openjdk bot commented Jun 28, 2023

@sid8606 This issue is referenced in the PR title - it will now be updated.

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for fixing.

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@sid8606 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch.

Reviewed-by: amitkumar, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 121 new commits pushed to the master branch:

  • 60544f9: 8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0
  • 0916e6a: 8311092: Please disable runtime/jni/nativeStack/TestNativeStack.java on armhf
  • d8a0121: 8311109: tautological-compare warning in awt_Win32GraphicsDevice.cpp
  • b9198f9: 8254566: Clarify the spec of ClassLoader::getClassLoadingLock for non-parallel capable loader
  • f393975: 8310743: assert(reserved_rgn != nullptr) failed: Add committed region, No reserved region found
  • ba974d5: 8310661: JFR: Replace JVM.getJVM() with JVM
  • 496f94b: 8311086: Remove jtreg/gc/startup_warnings
  • 9d2e0b2: 8307934: JRobot.moveMouseTo must access component on EDT
  • 87c79c0: 8309302: java/net/Socket/Timeouts.java fails with AssertionError on test temporal post condition
  • 8e0ca8e: 8310331: JitTester: Exclude java.lang.Math.random
  • ... and 111 more: https://git.openjdk.org/jdk/compare/78c3831701667069e7e048cd56b534ae2d8d15a1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@offamitkumar, @RealLucy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 30, 2023
@sid8606
Copy link
Member Author

sid8606 commented Jun 30, 2023

Thank you fro review @RealLucy.
Do I need a one more review to integrate or it's trivial change?

@sid8606
Copy link
Member Author

sid8606 commented Jul 4, 2023

Thank you for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Jul 4, 2023

@sid8606
Your change (at version 7f5eed4) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 4, 2023
@offamitkumar
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 4, 2023

Going to push as commit 514816e.
Since your change was applied there have been 121 commits pushed to the master branch:

  • 60544f9: 8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0
  • 0916e6a: 8311092: Please disable runtime/jni/nativeStack/TestNativeStack.java on armhf
  • d8a0121: 8311109: tautological-compare warning in awt_Win32GraphicsDevice.cpp
  • b9198f9: 8254566: Clarify the spec of ClassLoader::getClassLoadingLock for non-parallel capable loader
  • f393975: 8310743: assert(reserved_rgn != nullptr) failed: Add committed region, No reserved region found
  • ba974d5: 8310661: JFR: Replace JVM.getJVM() with JVM
  • 496f94b: 8311086: Remove jtreg/gc/startup_warnings
  • 9d2e0b2: 8307934: JRobot.moveMouseTo must access component on EDT
  • 87c79c0: 8309302: java/net/Socket/Timeouts.java fails with AssertionError on test temporal post condition
  • 8e0ca8e: 8310331: JitTester: Exclude java.lang.Math.random
  • ... and 111 more: https://git.openjdk.org/jdk/compare/78c3831701667069e7e048cd56b534ae2d8d15a1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 4, 2023
@openjdk openjdk bot closed this Jul 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 4, 2023
@openjdk
Copy link

openjdk bot commented Jul 4, 2023

@offamitkumar @sid8606 Pushed as commit 514816e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sid8606 sid8606 deleted the S390_linktitonative branch July 6, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants