8310902: (fc) FileChannel.transferXXX async close and interrupt issues

[AlanBateman]

This change fixes a number of bugs with FileChannel.transferTo/transerFrom that arise when the source or target channel is closed, or the thread is interrupted, during the transfer. More specifically:

• The direct implementations operate on the raw file descriptor and don't prevent the target/source channel from being closed during the transfer. For this PR, the direct transferTo is limited to cases where the target is a FileChannel or SocketChannel. It could be extended to other SelChImpl implementations (SinkChannel, DatagramChannel) if needed, but they are less interesting at this time.

• The transferTo/transferFrom methods are specified to throw ClosedByInterruptException after closing both channels. This is implemented inconsistently, and leaves one channel open in several cases.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310902: (fc) FileChannel.transferXXX async close and interrupt issues (Bug - P3)

Reviewers

• Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14656/head:pull/14656
$ git checkout pull/14656

Update a local copy of the PR:
$ git checkout pull/14656
$ git pull https://git.openjdk.org/jdk.git pull/14656/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14656

View PR using the GUI difftool:
$ git pr show -t 14656

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14656.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AlanBateman The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (182f8c05)
• 02: Full - Incremental (639372ca)
• 01: Full - Incremental (d5d8f742)
• 00: Full (d4ba2d05)

[bplb]

Should this be instead testInterruptTransferDuringTransferFrom for consistency with testInterruptDuringTransferTo?

[AlanBateman]

Is there a typo here, I can't quite see it.

[bplb]

Last changes look good. Approved.

[openjdk]

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310902: (fc) FileChannel.transferXXX async close and interrupt issues

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• ded1370: 8309811: BytecodePrinter cannot handle unlinked classes
• 02b17d7: 8310264: In PhaseChaitin::Split defs and phis are leaked
• a63afa4: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
• 3df36c4: 8310061: Note if implicit annotation processing is being used
• da0f832: 8310606: Fix signed integer overflow, part 3
• f0c2f09: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected.
• 9f46fc2: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files.
• 7fffdb5: 8310405: Linker.Option.firstVariadicArg should specify which index values are valid
• b6c789f: 8309140: ResourceHashtable failed "assert(~(_allocation_t[0] | allocation_mask) == (uintptr_t)this) failed: lost resource object"
• 9f98136: 6956385: URLConnection.getLastModified() leaks file handles for jar:file and file: URLs
• ... and 10 more: https://git.openjdk.org/jdk/compare/48e61c1df53c11ed49603abd70a3dd62a25f7be5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlanBateman]

/integrate

[openjdk]

Going to push as commit f4b900b.
Since your change was applied there have been 23 commits pushed to the master branch:

• cf8d706: 8308463: Refactor regenerated class handling in lambdaFormInvokers.cpp
• 6f58ab2: 8301569: jmod list option and jimage list --help not interpreted correctly on turkish locale
• 8f5a384: 8311032: Empty value for java.protocol.handler.pkgs system property can lead to unnecessary classloading attempts of protocol handlers
• ded1370: 8309811: BytecodePrinter cannot handle unlinked classes
• 02b17d7: 8310264: In PhaseChaitin::Split defs and phis are leaked
• a63afa4: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
• 3df36c4: 8310061: Note if implicit annotation processing is being used
• da0f832: 8310606: Fix signed integer overflow, part 3
• f0c2f09: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected.
• 9f46fc2: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files.
• ... and 13 more: https://git.openjdk.org/jdk/compare/48e61c1df53c11ed49603abd70a3dd62a25f7be5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman Pushed as commit f4b900b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.