Skip to content

Conversation

@mpdonova
Copy link
Contributor

@mpdonova mpdonova commented Jun 26, 2023

In this PR, I updated the test to use read time-outs. The test is restarted if the read operations time-out within (default) 30 seconds. The test makes 5 attempts before giving up.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14658/head:pull/14658
$ git checkout pull/14658

Update a local copy of the PR:
$ git checkout pull/14658
$ git pull https://git.openjdk.org/jdk.git pull/14658/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14658

View PR using the GUI difftool:
$ git pr show -t 14658

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14658.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2023

👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 26, 2023
@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@mpdonova The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 26, 2023

Webrevs

@mpdonova
Copy link
Contributor Author

I'm looking for a reviewer on this, thanks!

private static final String DTLS = "DTLS";
private static final String DTLSV_1_2 = "DTLSv1.2";

private static final int READ_TIMEOUT_SECS = Integer.getInteger("readtimeout", 30);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit on line 37 (since I can't flag that directly): Maybe add 8310070 to the @bug line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On previous PRs, I've been told that test-only updates don't need the bug id.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Then as far as I'm concerned you're good to go.

Copy link
Member

@jnimeh jnimeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the nit, looks good to me.

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out

Reviewed-by: jnimeh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 216 new commits pushed to the master branch:

  • 8c9d091: 8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors
  • b587fc5: 8312013: avoid UnixConstants.java.template warning: 'linux' is not defined on AIX
  • 135f64e: 8311583: tableswitch broken by JDK-8310577
  • 6895deb: 8311536: JFR TestNativeMemoryUsageEvents fails in huge pages configuration
  • bb5278d: 8311239: GC: Remove trailing blank lines in source files
  • 92a04e2: 8311867: StructuredTaskScope.shutdown does not interrupt newly started threads
  • f60c1f9: 8294401: Update jfr man page to include recently added features
  • 1b0dd7c: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified
  • a38a421: 8311917: MAP_FAILED definition seems to be obsolete in src/java.desktop/unix/native/common/awt/fontpath.c
  • 812dadb: 8311788: ClassLoadUnloadTest fails on AIX after JDK-8193513
  • ... and 206 more: https://git.openjdk.org/jdk/compare/4bf78162c52564645af79b8324b69d89102dc024...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 13, 2023
@mpdonova
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

Going to push as commit af7f95e.
Since your change was applied there have been 218 commits pushed to the master branch:

  • c710e71: 8311102: Write annotations in the classfile dumped by SA
  • 61932f4: 8244289: fatal error: Possible safepoint reached by thread that does not allow it
  • 8c9d091: 8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors
  • b587fc5: 8312013: avoid UnixConstants.java.template warning: 'linux' is not defined on AIX
  • 135f64e: 8311583: tableswitch broken by JDK-8310577
  • 6895deb: 8311536: JFR TestNativeMemoryUsageEvents fails in huge pages configuration
  • bb5278d: 8311239: GC: Remove trailing blank lines in source files
  • 92a04e2: 8311867: StructuredTaskScope.shutdown does not interrupt newly started threads
  • f60c1f9: 8294401: Update jfr man page to include recently added features
  • 1b0dd7c: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified
  • ... and 208 more: https://git.openjdk.org/jdk/compare/4bf78162c52564645af79b8324b69d89102dc024...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 13, 2023
@openjdk openjdk bot closed this Jul 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@mpdonova Pushed as commit af7f95e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants