Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8310909: java.io.InvalidObjectException has redundant @since tag #14662

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Jun 26, 2023

Please review a trivial update to remove a redundant @since tag.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310909: java.io.InvalidObjectException has redundant @since tag (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14662/head:pull/14662
$ git checkout pull/14662

Update a local copy of the PR:
$ git checkout pull/14662
$ git pull https://git.openjdk.org/jdk.git pull/14662/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14662

View PR using the GUI difftool:
$ git pr show -t 14662

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14662.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2023

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 26, 2023
@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 26, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310909: java.io.InvalidObjectException has redundant `@since` tag

Reviewed-by: lancea, naoto, bpb, darcy, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a08352f: 8305671: javac rejects semicolons in compilation units with no imports
  • ff9a754: 8310459: [BACKOUT] 8304450: [vectorapi] Refactor VectorShuffle implementation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 26, 2023
@jonathan-gibbons
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 26, 2023

Going to push as commit 46add3f.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 8f5b677: 8310908: Non-standard @since tag in com.sun.java.accessibility.util.package-info
  • a197ee7: 8310838: Correct range notations in MethodTypeDesc specification
  • 7c6a28f: 8310922: java/lang/Class/forName/ForNameNames.java fails after being added by JDK-8310242
  • 7db2f08: 8310242: Clarify the name parameter to Class::forName
  • 297c799: 8301492: Modernize equals() method of ResourceBundle.CacheKey and Bundles.CacheKey
  • a08352f: 8305671: javac rejects semicolons in compilation units with no imports
  • ff9a754: 8310459: [BACKOUT] 8304450: [vectorapi] Refactor VectorShuffle implementation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 26, 2023
@openjdk openjdk bot closed this Jun 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 26, 2023
@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@jonathan-gibbons Pushed as commit 46add3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the 8310909.InvalidObjectException branch June 26, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

6 participants