8310920: Fix -Wconversion warnings in command line flags

[coleenp]

This is broken out from but tested with the PR from #14659

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310920: Fix -Wconversion warnings in command line flags (Enhancement - P4)

Reviewers

• Ioi Lam (@iklam - Reviewer) ⚠️ Review applies to 19baa252
• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 95ee731c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14665/head:pull/14665
$ git checkout pull/14665

Update a local copy of the PR:
$ git checkout pull/14665
$ git pull https://git.openjdk.org/jdk.git pull/14665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14665

View PR using the GUI difftool:
$ git pr show -t 14665

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14665.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (41b02544)
• 01: Full - Incremental (95ee731c)
• 00: Full (19baa252)

[iklam]

LGTM and looks like a trivial change.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310920: Fix -Wconversion warnings in command line flags

Reviewed-by: iklam, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 7f09435: 8310982: jdk/internal/util/ArchTest.java fails after JDK-8308452 failed with Method isARM()
• f07e396: 8310914: Remove 2 malformed java/foreign ProblemList entries
• a97f98f: 8310585: GetThreadState spec mentions undefined JVMTI_THREAD_STATE_MONITOR_WAITING
• 2cf5c2f: 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails
• 269852b: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x
• 4bce38c: 8310830: typo in the parameter name in @throws of ClassDesc::ofDescriptor
• 315242b: 8310975: java.util.FormatItemModifier should not be protected
• d6dd0dc: 8308452: Extend internal Architecture enum with byte order and address size
• fb283df: 8310828: java.sql java.sql.rowset packages have no @since info
• ec45bd6: 8310182: DateTimeFormatter date formats (ISO_LOCAL_DATE) separated with hyphen, not dash
• ... and 16 more: https://git.openjdk.org/jdk/compare/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

If the constraint phase is an enum, why isn't it being typed as an enum rather than char?

[coleenp]

With a few more changes, the enum JVMFlagconstraintPhase can be used rather than char.

[dholmes-ora]

Phase changes look good - thanks!

One minor nit below but approved.

[coleenp]

Thanks Ioi and David for reviewing.
/integrate

[openjdk]

Going to push as commit 08c51f2.
Since your change was applied there have been 34 commits pushed to the master branch:

• c2e9485: 8310921: Fix -Wconversion warnings from GenerateOopMap
• ef71c32: 8310110: Shenandoah: Trace page sizes
• c3f10e8: 8307625: Redundant receiver null check in LibraryCallKit::generate_method_call
• 39c104d: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work
• 526dba1: 8310130: C2: assert(false) failed: scalar_input is neither phi nor a matchin reduction
• 48e61c1: 8310728: Enable Zc:inline flag in Visual Studio build
• 56a73a6: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level
• afdaa2a: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1
• 7f09435: 8310982: jdk/internal/util/ArchTest.java fails after JDK-8308452 failed with Method isARM()
• f07e396: 8310914: Remove 2 malformed java/foreign ProblemList entries
• ... and 24 more: https://git.openjdk.org/jdk/compare/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 08c51f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.