Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257184: Upstream 8252504: Add a method to MemoryLayout which returns a offset-computing method handle #1468

Closed
wants to merge 3 commits into from

Conversation

@JornVernee
Copy link
Member

@JornVernee JornVernee commented Nov 26, 2020

This upstreams the patch from: openjdk/panama-foreign#396

There were only some minor merge conflicts due to imports and some tests being replaced by java/foreign/TestNulls. All tests still pass, no other changes were needed.

CSR: https://bugs.openjdk.java.net/browse/JDK-8257187


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257184: Upstream 8252504: Add a method to MemoryLayout which returns a offset-computing method handle

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1468/head:pull/1468
$ git checkout pull/1468

@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented Nov 26, 2020

/csr

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 26, 2020

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

@JornVernee this pull request will not be integrated until the CSR request JDK-8257187 for issue JDK-8257184 has been approved.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Nov 26, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 26, 2020

Webrevs

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Looks good

- remove explicit @throws NPE tags
- add example to class doc
@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented Nov 27, 2020

All good suggestions. I've implemented them now.

Copy link
Member

@ChrisHegarty ChrisHegarty left a comment

Thanks for considering the comments. Looks good to me.

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Very nice

…MemoryLayout.java

Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore@users.noreply.github.com>
@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented Nov 27, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

@JornVernee This PR has not yet been marked as ready for integration.

@openjdk openjdk bot removed the csr label Dec 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2020

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257184: Upstream 8252504: Add a method to MemoryLayout which returns a offset-computing method handle

Reviewed-by: mcimadamore, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 157 new commits pushed to the master branch:

  • e590618: 8252505: C1/C2 compiler support for blackholes
  • 972bc3b: 8256167: Convert JDK use of Reference::get to Reference::refersTo
  • 78be334: 8242332: Add SHA3 support to SunPKCS11 provider
  • c4339c3: 8243614: Typo in ReentrantLock's Javadoc
  • d3ac1bf: 8198390: Test MultiResolutionDrawImageWithTransformTest.java fails when -esa is passed
  • 51d325e: 8257633: Missing -mmacosx-version-min=X flag when linking libjvm
  • e27ea4d: 8257750: writeBuffer field of java.io.DataOutputStream should be final
  • dd0b945: 8257531: Super word not applied to a loop of simple Buffer operations
  • d76039d: 8257725: No throws of SSLHandshakeException
  • fcc8479: 8257724: Incorrect package of the linked class in BaseSSLSocketImpl
  • ... and 147 more: https://git.openjdk.java.net/jdk/compare/6e0062236c836b261cde5792963fb9de3068b8f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 7, 2020
@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented Dec 7, 2020

/integrate

@openjdk openjdk bot closed this Dec 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2020

@JornVernee Since your change was applied there have been 165 commits pushed to the master branch:

  • 5a03e47: 8255560: Class::isRecord should check that the current class is final and not abstract
  • 8e8e584: 8257588: Make os::_page_sizes a bitmask
  • 566d77a: 8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY"
  • f5a582c: 8257575: C2: "failed: only phis" assert failure in loop strip mining verification
  • d05401d: 8256679: Update serialization javadoc once JOSS changes for records are complete
  • 7620124: 8257230: assert(InitialHeapSize >= MinHeapSize) failed: Ergonomics decided on incompatible initial and minimum heap sizes
  • 05dac03: 8257803: Add -Xbatch to compiler/blackhole tests
  • 29a09c8: 8257668: SA JMap - skip non-java thread stack dump for heap dump
  • e590618: 8252505: C1/C2 compiler support for blackholes
  • 972bc3b: 8256167: Convert JDK use of Reference::get to Reference::refersTo
  • ... and 155 more: https://git.openjdk.java.net/jdk/compare/6e0062236c836b261cde5792963fb9de3068b8f7...master

Your commit was automatically rebased without conflicts.

Pushed as commit 04ce8e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants