8310982: jdk/internal/util/ArchTest.java fails after JDK-8308452 failed with Method isARM()#14685
8310982: jdk/internal/util/ArchTest.java fails after JDK-8308452 failed with Method isARM()#14685RogerRiggs wants to merge 2 commits intoopenjdk:masterfrom
Conversation
…ed with "Method isARM()..." Correct expected result for isArm when running on aarch64.
|
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
|
@RogerRiggs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 7f09435.
Your commit was automatically rebased without conflicts. |
|
@RogerRiggs Pushed as commit 7f09435. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Fix a test bug when run on aarch64, it was supposed to confirm it was not running on Arm.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14685/head:pull/14685$ git checkout pull/14685Update a local copy of the PR:
$ git checkout pull/14685$ git pull https://git.openjdk.org/jdk.git pull/14685/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14685View PR using the GUI difftool:
$ git pr show -t 14685Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14685.diff
Webrev
Link to Webrev Comment