8311007: jdk/jfr/tool/TestView.java can't find event

[egahlin]

Could I have a review of a test fix that ensures that the event timestamp are in sync. with the timestamp used by 'jcmd view'.

Testing: test/jdk/jdk/jfr/jcmd/TestJcmdView.java

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311007: jdk/jfr/tool/TestView.java can't find event (Bug - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14686/head:pull/14686
$ git checkout pull/14686

Update a local copy of the PR:
$ git checkout pull/14686
$ git pull https://git.openjdk.org/jdk.git pull/14686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14686

View PR using the GUI difftool:
$ git pr show -t 14686

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14686.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (047f7457)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311007: jdk/jfr/tool/TestView.java can't find event

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• c3f10e8: 8307625: Redundant receiver null check in LibraryCallKit::generate_method_call
• 39c104d: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work
• 526dba1: 8310130: C2: assert(false) failed: scalar_input is neither phi nor a matchin reduction
• 48e61c1: 8310728: Enable Zc:inline flag in Visual Studio build
• 56a73a6: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level
• afdaa2a: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit e3f18af.
Since your change was applied there have been 9 commits pushed to the master branch:

• 08c51f2: 8310920: Fix -Wconversion warnings in command line flags
• c2e9485: 8310921: Fix -Wconversion warnings from GenerateOopMap
• ef71c32: 8310110: Shenandoah: Trace page sizes
• c3f10e8: 8307625: Redundant receiver null check in LibraryCallKit::generate_method_call
• 39c104d: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work
• 526dba1: 8310130: C2: assert(false) failed: scalar_input is neither phi nor a matchin reduction
• 48e61c1: 8310728: Enable Zc:inline flag in Visual Studio build
• 56a73a6: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level
• afdaa2a: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit e3f18af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[egahlin]

/backport jdk21

[openjdk]

@egahlin the backport was successfully created on the branch egahlin-backport-e3f18af1 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e3f18af1 from the openjdk/jdk repository.

The commit being backported was authored by Erik Gahlin on 28 Jun 2023 and was reviewed by Markus Grönlund.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git egahlin-backport-e3f18af1:egahlin-backport-e3f18af1
$ git checkout egahlin-backport-e3f18af1
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git egahlin-backport-e3f18af1