8311020: Typo cleanup in Classfile API

[liach]

This is a cleanup patch that fixes:

1. ClassfileBuilder should be sealed but was not; it's now sealed.
2. Various typo fixes, including spelling errors, wrong descriptions, and unnecessary full qualifications for classes in the same package.

Requesting a review from @asotona. There's a few other more complex issues discovered, which I will describe on the mailing list to elicit a discussion for best solutions.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311020: Typo cleanup in Classfile API (Bug - P4)

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14687/head:pull/14687
$ git checkout pull/14687

Update a local copy of the PR:
$ git checkout pull/14687
$ git pull https://git.openjdk.org/jdk.git pull/14687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14687

View PR using the GUI difftool:
$ git pr show -t 14687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14687.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (675774b5)
• 00: Full (e2dd9184)

[asotona]

Here the same typo is repeated in ClassPrinterTest, which actually fails after the fix.

[liach]

Thanks for the reminder. I've checked IDE-reported typos in the tests and fixed 2; jdk.classfile tests pass on my machine now.

[asotona]

Thank you for fixing the typos.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311020: Typo cleanup in Classfile API

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 6f58ab2: 8301569: jmod list option and jimage list --help not interpreted correctly on turkish locale
• 8f5a384: 8311032: Empty value for java.protocol.handler.pkgs system property can lead to unnecessary classloading attempts of protocol handlers
• ded1370: 8309811: BytecodePrinter cannot handle unlinked classes
• 02b17d7: 8310264: In PhaseChaitin::Split defs and phis are leaked
• a63afa4: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
• 3df36c4: 8310061: Note if implicit annotation processing is being used
• da0f832: 8310606: Fix signed integer overflow, part 3
• f0c2f09: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected.
• 9f46fc2: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files.
• 7fffdb5: 8310405: Linker.Option.firstVariadicArg should specify which index values are valid
• ... and 14 more: https://git.openjdk.org/jdk/compare/afdaa2a3305461538f3a36de2b0b540fe2da9b37...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@asotona) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[liach]

/integrate

[openjdk]

@liach
Your change (at version 675774b) is now ready to be sponsored by a Committer.

[asotona]

/sponsor

[openjdk]

Going to push as commit cbf418a.
Since your change was applied there have been 26 commits pushed to the master branch:

• f4b900b: 8310902: (fc) FileChannel.transferXXX async close and interrupt issues
• cf8d706: 8308463: Refactor regenerated class handling in lambdaFormInvokers.cpp
• 6f58ab2: 8301569: jmod list option and jimage list --help not interpreted correctly on turkish locale
• 8f5a384: 8311032: Empty value for java.protocol.handler.pkgs system property can lead to unnecessary classloading attempts of protocol handlers
• ded1370: 8309811: BytecodePrinter cannot handle unlinked classes
• 02b17d7: 8310264: In PhaseChaitin::Split defs and phis are leaked
• a63afa4: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
• 3df36c4: 8310061: Note if implicit annotation processing is being used
• da0f832: 8310606: Fix signed integer overflow, part 3
• f0c2f09: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected.
• ... and 16 more: https://git.openjdk.org/jdk/compare/afdaa2a3305461538f3a36de2b0b540fe2da9b37...master

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona @liach Pushed as commit cbf418a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.