Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311046: ProblemList gc/z/TestHighUsage.java with Generational ZGC #14697

Closed
wants to merge 1 commit into from

Conversation

xmas92
Copy link
Member

@xmas92 xmas92 commented Jun 28, 2023

Problemlist gc/z/TestHighUsage.java for generic-all to reduce noise in the CI pipeline until JDK-8308843 can be reevaluated.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311046: ProblemList gc/z/TestHighUsage.java with Generational ZGC (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14697/head:pull/14697
$ git checkout pull/14697

Update a local copy of the PR:
$ git checkout pull/14697
$ git pull https://git.openjdk.org/jdk.git pull/14697/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14697

View PR using the GUI difftool:
$ git pr show -t 14697

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14697.diff

@xmas92 xmas92 changed the title ProblemList gc/z/TestHighUsage.java with Generational ZGC 8311046: ProblemList gc/z/TestHighUsage.java with Generational ZGC Jun 28, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2023

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 28, 2023
@openjdk
Copy link

openjdk bot commented Jun 28, 2023

@xmas92 To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311046: ProblemList gc/z/TestHighUsage.java with Generational ZGC

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 77e7b6d: 8311074: RISC-V: Fix -Wconversion warnings in some code header files
  • 11fd34e: 8310241: OffsetDateTime compareTo redundant computation
  • d979662: 8311115: Type in java.lang.reflect.AccessFlag.METHOD_PARAMETER
  • a995aa6: 8310232: java.time.Clock$TickClock.millis() fails in runtime when tick is 1 microsecond
  • 26efff7: 8309902: C2: assert(false) failed: Bad graph detected in build_loop_late after JDK-8305189
  • 05c2b6c: 8309979: BootstrapMethods attribute is missing in class files recreated by SA
  • 20f7d05: 8310502: Optimization for j.l.Long.fastUUID()
  • 07734f6: 8310848: Convert ClassDesc and MethodTypeDesc to be stored in static final fields
  • e5744b8: 8310919: runtime/ErrorHandling/TestAbortVmOnException.java times out due to core dumps taking a long time on OSX
  • 98a954e: 8308286: Fix clang warnings in linux code
  • ... and 22 more: https://git.openjdk.org/jdk/compare/2ccdd29206d5041b067fac4e3c3b248e8d0aa3df...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 30, 2023
@xmas92
Copy link
Member Author

xmas92 commented Jun 30, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

Going to push as commit 2a9e2f6.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 77e7b6d: 8311074: RISC-V: Fix -Wconversion warnings in some code header files
  • 11fd34e: 8310241: OffsetDateTime compareTo redundant computation
  • d979662: 8311115: Type in java.lang.reflect.AccessFlag.METHOD_PARAMETER
  • a995aa6: 8310232: java.time.Clock$TickClock.millis() fails in runtime when tick is 1 microsecond
  • 26efff7: 8309902: C2: assert(false) failed: Bad graph detected in build_loop_late after JDK-8305189
  • 05c2b6c: 8309979: BootstrapMethods attribute is missing in class files recreated by SA
  • 20f7d05: 8310502: Optimization for j.l.Long.fastUUID()
  • 07734f6: 8310848: Convert ClassDesc and MethodTypeDesc to be stored in static final fields
  • e5744b8: 8310919: runtime/ErrorHandling/TestAbortVmOnException.java times out due to core dumps taking a long time on OSX
  • 98a954e: 8308286: Fix clang warnings in linux code
  • ... and 22 more: https://git.openjdk.org/jdk/compare/2ccdd29206d5041b067fac4e3c3b248e8d0aa3df...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 30, 2023
@openjdk openjdk bot closed this Jun 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@xmas92 Pushed as commit 2a9e2f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants