Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253084: Zero VM is broken after JDK-8252689 #147

Closed
wants to merge 1 commit into from

Conversation

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Sep 14, 2020

Hi all,

JBS: https://bugs.openjdk.java.net/browse/JDK-8253084

The build fails due to 'NULL' can't be converted from type 'long' to type 'Handle'
The fix returns 'Handle()' instead of 'NULL'.

Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/147/head:pull/147
$ git checkout pull/147

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Sep 14, 2020

/issue add JDK-8253084
/test

/label add hotspot-runtime

/cc hotspot-runtime

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 14, 2020

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@DamonFool This issue is referenced in the PR title - it will now be updated.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@DamonFool
The hotspot-runtime label was successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@DamonFool The hotspot-runtime label was already applied.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@DamonFool To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request.

In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the /label add "label" command. The following labels are valid: 2d awt beans build compiler core-libs hotspot hotspot-compiler hotspot-gc hotspot-jfr hotspot-runtime i18n javadoc jdk jmx kulla net nio security serviceability shenandoah sound swing.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2020

Webrevs

Loading

iklam
iklam approved these changes Sep 14, 2020
Copy link
Member

@iklam iklam left a comment

LGTM. This is a trivial change so you don't need to wait for a second reviewer. Thanks!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@DamonFool This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253084: Zero VM is broken after JDK-8252689

Reviewed-by: iklam
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 07da3a1: 8253030: ZGC: Change ZMarkCompleteTimeout unit to microseconds

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 07da3a18083cd84bfdb1c0d68476d72482755125.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 14, 2020
@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Sep 14, 2020

Thanks Ioi for your review.

/integrate

Loading

@openjdk openjdk bot closed this Sep 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@DamonFool Since your change was applied there has been 1 commit pushed to the master branch:

  • 07da3a1: 8253030: ZGC: Change ZMarkCompleteTimeout unit to microseconds

Your commit was automatically rebased without conflicts.

Pushed as commit 779d2c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@DamonFool DamonFool deleted the JDK-8253084 branch Sep 14, 2020
@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Sep 14, 2020

Thanks David for your review.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants