8311084: Add typeSymbol() API for applicable constant pool entries #14706

liach · 2023-06-29T09:59:30Z

5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry, FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or MethodTypeDesc).

This API is not added to NameAndTypeEntry itself, for a NameAndTypeEntry only knows if its type should be a field or method type from the other entries that refer to it.

This is one of the issues discussed in this mailing list thread: https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8311084: Add typeSymbol() API for applicable constant pool entries (Enhancement - P4)

Reviewers

Brian Goetz (@briangoetz - Reviewer) ⚠️ Review applies to d2701993
Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14706/head:pull/14706
$ git checkout pull/14706

Update a local copy of the PR:
$ git checkout pull/14706
$ git pull https://git.openjdk.org/jdk.git pull/14706/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14706

View PR using the GUI difftool:
$ git pr show -t 14706

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14706.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-06-29T10:01:10Z

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-06-29T10:02:41Z

@liach The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-06-29T13:15:10Z

Webrevs

briangoetz · 2023-06-29T13:19:30Z

src/java.base/share/classes/jdk/internal/classfile/constantpool/ConstantDynamicEntry.java

+     */
+    default ClassDesc typeSymbol() {
+        return Util.fieldTypeSymbol(nameAndType());
+    }


Usage of Util::fieldTypeSymbol in asSymbol() can be replaced with typeSymbol()

briangoetz · 2023-06-29T13:23:51Z

src/java.base/share/classes/jdk/internal/classfile/constantpool/InvokeDynamicEntry.java

+     */
+    default MethodTypeDesc typeSymbol() {
+        return Util.methodTypeSymbol(nameAndType());
+    }


Similar comment as with CondyEntry -- reduce usage of Util::methodTypeSymbol in this class

(Would like to do the same in various ::count methods, but unfortunately MemberRefEntry is too general; would have to rejigger the various XxxRefEntry types.)

Which count methods are you referring to, Brian?

openjdk · 2023-06-29T13:28:09Z

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311084: Add typeSymbol() API for applicable constant pool entries

Reviewed-by: briangoetz, asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

8412479: 8316229: Enhance class initialization logging
c04c9ea: 8316627: JViewport Test headless failure
5cacf21: 8316156: ByteArrayInputStream.transferTo causes MaxDirectMemorySize overflow
3461c7b: 8316532: Native library copying in BuildMicrobenchmark.gmk cause dups on macOS
3301fb1: 8315869: UseHeavyMonitors not used
54028e7: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829
7c991cc: 8296246: Update Unicode Data Files to Version 15.1.0
a021dbc: 8316149: Open source several Swing JTree JViewport KeyboardManager tests
455cfae: 8315880: change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
9e00949: 8316427: Duplicated code for {obj,type}ArrayKlass::array_klass
... and 5 more: https://git.openjdk.org/jdk/compare/ec74194cb75afcaab2f77e8728391bb9104ccc73...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@briangoetz, @asotona) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

bridgekeeper · 2023-07-28T07:08:03Z

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2023-08-25T12:00:30Z

@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

…cpentry-typesym

liach · 2023-09-20T07:25:49Z

/open

openjdk · 2023-09-20T07:27:50Z

@liach This pull request is now open

liach · 2023-09-20T07:30:17Z

@asotona Can you review this Classfile API utility addition?

asotona

It looks good, thanks for the patch.

liach · 2023-09-21T02:16:45Z

/integrate

openjdk · 2023-09-21T02:18:17Z

@liach
Your change (at version dd28873) is now ready to be sponsored by a Committer.

asotona · 2023-09-21T08:03:38Z

/sponsor

openjdk · 2023-09-21T08:05:04Z

Going to push as commit 1749ba2.
Since your change was applied there have been 20 commits pushed to the master branch:

9f5d2b9: 8316285: Opensource JButton manual tests
a35e96a: 8313612: Use JUnit in lib-test/jdk tests
bee7524: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX
ceff47b: 8315082: [REDO] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
df4a25b: 8308762: Metaspace leak with Instrumentation.retransform
8412479: 8316229: Enhance class initialization logging
c04c9ea: 8316627: JViewport Test headless failure
5cacf21: 8316156: ByteArrayInputStream.transferTo causes MaxDirectMemorySize overflow
3461c7b: 8316532: Native library copying in BuildMicrobenchmark.gmk cause dups on macOS
3301fb1: 8315869: UseHeavyMonitors not used
... and 10 more: https://git.openjdk.org/jdk/compare/ec74194cb75afcaab2f77e8728391bb9104ccc73...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-09-21T08:05:18Z

@asotona @liach Pushed as commit 1749ba2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Add typeSymbol API for a few constant pool entries

d270199

openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 29, 2023

liach marked this pull request as ready for review June 29, 2023 13:09

openjdk bot added the rfr Pull request is ready for review label Jun 29, 2023

briangoetz approved these changes Jun 29, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 29, 2023

Use typeSymbol in asSymbol

3ae616e

bridgekeeper bot closed this Aug 25, 2023

liach added 2 commits September 1, 2023 10:57

Merge branch 'master' of https://github.com/openjdk/jdk into feature/…

0044de0

…cpentry-typesym

Merge branch 'master' into feature/cpentry-typesym

dd28873

openjdk bot reopened this Sep 20, 2023

asotona approved these changes Sep 20, 2023

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 21, 2023

openjdk bot added the integrated Pull request has been integrated label Sep 21, 2023

openjdk bot closed this Sep 21, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 21, 2023

openjdk bot removed the sponsor Pull request is ready to be sponsored label Sep 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8311084: Add typeSymbol() API for applicable constant pool entries #14706

8311084: Add typeSymbol() API for applicable constant pool entries #14706

liach commented Jun 29, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jun 29, 2023

openjdk bot commented Jun 29, 2023

mlbridge bot commented Jun 29, 2023 •

edited

Loading

briangoetz Jun 29, 2023

briangoetz Jun 29, 2023

briangoetz Jun 29, 2023

liach Jun 30, 2023

openjdk bot commented Jun 29, 2023 •

edited

Loading

bridgekeeper bot commented Jul 28, 2023

bridgekeeper bot commented Aug 25, 2023

liach commented Sep 20, 2023

openjdk bot commented Sep 20, 2023

liach commented Sep 20, 2023

asotona left a comment

liach commented Sep 21, 2023

openjdk bot commented Sep 21, 2023

asotona commented Sep 21, 2023

openjdk bot commented Sep 21, 2023

openjdk bot commented Sep 21, 2023

8311084: Add typeSymbol() API for applicable constant pool entries #14706

8311084: Add typeSymbol() API for applicable constant pool entries #14706

Conversation

liach commented Jun 29, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Jun 29, 2023

openjdk bot commented Jun 29, 2023

mlbridge bot commented Jun 29, 2023 • edited Loading

Webrevs

briangoetz Jun 29, 2023

Choose a reason for hiding this comment

briangoetz Jun 29, 2023

Choose a reason for hiding this comment

briangoetz Jun 29, 2023

Choose a reason for hiding this comment

liach Jun 30, 2023

Choose a reason for hiding this comment

openjdk bot commented Jun 29, 2023 • edited Loading

bridgekeeper bot commented Jul 28, 2023

bridgekeeper bot commented Aug 25, 2023

liach commented Sep 20, 2023

openjdk bot commented Sep 20, 2023

liach commented Sep 20, 2023

asotona left a comment

Choose a reason for hiding this comment

liach commented Sep 21, 2023

openjdk bot commented Sep 21, 2023

asotona commented Sep 21, 2023

openjdk bot commented Sep 21, 2023

openjdk bot commented Sep 21, 2023

liach commented Jun 29, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Jun 29, 2023 •

edited

Loading

openjdk bot commented Jun 29, 2023 •

edited

Loading