Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311000: missing @since info in jdk.management #14708

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Jun 29, 2023

Simple addition of a doc tag.

src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java is introduced in jdk7 by
7036199: Adding a notification to the implementation of GarbageCollectorMXBeans


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14708/head:pull/14708
$ git checkout pull/14708

Update a local copy of the PR:
$ git checkout pull/14708
$ git pull https://git.openjdk.org/jdk.git pull/14708/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14708

View PR using the GUI difftool:
$ git pr show -t 14708

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14708.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2023

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinjwalls kevinjwalls marked this pull request as ready for review June 29, 2023 11:50
@openjdk
Copy link

openjdk bot commented Jun 29, 2023

@kevinjwalls The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org rfr Pull request is ready for review labels Jun 29, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 29, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 29, 2023

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311000: missing @since info in jdk.management

Reviewed-by: rriggs, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 660cd25: 8310988: Missing @SInCE tags in java.management.rmi
  • 2a9e2f6: 8311046: ProblemList gc/z/TestHighUsage.java with Generational ZGC
  • 77e7b6d: 8311074: RISC-V: Fix -Wconversion warnings in some code header files
  • 11fd34e: 8310241: OffsetDateTime compareTo redundant computation
  • d979662: 8311115: Type in java.lang.reflect.AccessFlag.METHOD_PARAMETER
  • a995aa6: 8310232: java.time.Clock$TickClock.millis() fails in runtime when tick is 1 microsecond
  • 26efff7: 8309902: C2: assert(false) failed: Bad graph detected in build_loop_late after JDK-8305189
  • 05c2b6c: 8309979: BootstrapMethods attribute is missing in class files recreated by SA
  • 20f7d05: 8310502: Optimization for j.l.Long.fastUUID()
  • 07734f6: 8310848: Convert ClassDesc and MethodTypeDesc to be stored in static final fields
  • ... and 1 more: https://git.openjdk.org/jdk/compare/98a954eebc4f97dd16cb89bd4f1122952c8482ca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 29, 2023
@kevinjwalls
Copy link
Contributor Author

Thanks for the reviews.

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

Going to push as commit c08c983.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 660cd25: 8310988: Missing @SInCE tags in java.management.rmi
  • 2a9e2f6: 8311046: ProblemList gc/z/TestHighUsage.java with Generational ZGC
  • 77e7b6d: 8311074: RISC-V: Fix -Wconversion warnings in some code header files
  • 11fd34e: 8310241: OffsetDateTime compareTo redundant computation
  • d979662: 8311115: Type in java.lang.reflect.AccessFlag.METHOD_PARAMETER
  • a995aa6: 8310232: java.time.Clock$TickClock.millis() fails in runtime when tick is 1 microsecond
  • 26efff7: 8309902: C2: assert(false) failed: Bad graph detected in build_loop_late after JDK-8305189
  • 05c2b6c: 8309979: BootstrapMethods attribute is missing in class files recreated by SA
  • 20f7d05: 8310502: Optimization for j.l.Long.fastUUID()
  • 07734f6: 8310848: Convert ClassDesc and MethodTypeDesc to be stored in static final fields
  • ... and 1 more: https://git.openjdk.org/jdk/compare/98a954eebc4f97dd16cb89bd4f1122952c8482ca...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 30, 2023
@openjdk openjdk bot closed this Jun 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@kevinjwalls Pushed as commit c08c983.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants