Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311086: Remove jtreg/gc/startup_warnings #14709

Closed
wants to merge 1 commit into from

Conversation

lkorinth
Copy link
Contributor

@lkorinth lkorinth commented Jun 29, 2023

It does not seem important to check that certain GCs are not deprecated.

The test originally tested that we created deprecation warnings on features that are now removed. What is left is not worth having IMO.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311086: Remove jtreg/gc/startup_warnings (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14709/head:pull/14709
$ git checkout pull/14709

Update a local copy of the PR:
$ git checkout pull/14709
$ git pull https://git.openjdk.org/jdk.git pull/14709/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14709

View PR using the GUI difftool:
$ git pr show -t 14709

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14709.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2023

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 29, 2023
@openjdk
Copy link

openjdk bot commented Jun 29, 2023

@lkorinth The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 29, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 29, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 29, 2023

@lkorinth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311086: Remove jtreg/gc/startup_warnings

Reviewed-by: ayang, mli, kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 2a9e2f6: 8311046: ProblemList gc/z/TestHighUsage.java with Generational ZGC
  • 77e7b6d: 8311074: RISC-V: Fix -Wconversion warnings in some code header files
  • 11fd34e: 8310241: OffsetDateTime compareTo redundant computation
  • d979662: 8311115: Type in java.lang.reflect.AccessFlag.METHOD_PARAMETER
  • a995aa6: 8310232: java.time.Clock$TickClock.millis() fails in runtime when tick is 1 microsecond
  • 26efff7: 8309902: C2: assert(false) failed: Bad graph detected in build_loop_late after JDK-8305189
  • 05c2b6c: 8309979: BootstrapMethods attribute is missing in class files recreated by SA
  • 20f7d05: 8310502: Optimization for j.l.Long.fastUUID()
  • 07734f6: 8310848: Convert ClassDesc and MethodTypeDesc to be stored in static final fields
  • e5744b8: 8310919: runtime/ErrorHandling/TestAbortVmOnException.java times out due to core dumps taking a long time on OSX
  • ... and 20 more: https://git.openjdk.org/jdk/compare/9f98136c3a00ca24d59ffefd58308603b58110c7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 29, 2023
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lkorinth
Copy link
Contributor Author

lkorinth commented Jul 3, 2023

Thanks for your reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Jul 3, 2023

Going to push as commit 496f94b.
Since your change was applied there have been 54 commits pushed to the master branch:

  • 9d2e0b2: 8307934: JRobot.moveMouseTo must access component on EDT
  • 87c79c0: 8309302: java/net/Socket/Timeouts.java fails with AssertionError on test temporal post condition
  • 8e0ca8e: 8310331: JitTester: Exclude java.lang.Math.random
  • 055b4b4: 8310948: Fix ignored-qualifiers warning in Hotspot
  • 2c29705: 8309660: C2: failed: XMM register should be 0-15 (UseKNLSetting and ConvF2HF)
  • 52ee570: 8309209: C2 failed "assert(_stack_guard_state == stack_guard_reserved_disabled) failed: inconsistent state"
  • faf1b82: 8310656: RISC-V: __builtin___clear_cache can fail silently.
  • 0e3d91d: 8311215: [BACKOUT] JDK-8047998 Abort the vm if MaxNewSize is not the same as NewSize when MaxHeapSize is the same as InitialHeapSize
  • 09a4924: 8311145: Remove check_with_errno duplicates
  • 8abb9f5: 8047998: Abort the vm if MaxNewSize is not the same as NewSize when MaxHeapSize is the same as InitialHeapSize
  • ... and 44 more: https://git.openjdk.org/jdk/compare/9f98136c3a00ca24d59ffefd58308603b58110c7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 3, 2023
@openjdk openjdk bot closed this Jul 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 3, 2023
@openjdk
Copy link

openjdk bot commented Jul 3, 2023

@lkorinth Pushed as commit 496f94b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants