-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8310988: Missing @since tags in java.management.rmi #14714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into |
|
@kevinjwalls The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
@kevinjwalls This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
AlanBateman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, I assume you'll bump the copyright date before integrating.
Will do. |
|
Thanks for the reviews! |
|
/integrate |
|
Going to push as commit 660cd25.
Your commit was automatically rebased without conflicts. |
|
@kevinjwalls Pushed as commit 660cd25. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Simple doc tag addition.
These are files which describe an interface that has been with us since 1.5. The files themselves were previously generated at build time, but have been in the repo since jdk15. But the API is since 1.5.
The other file mentioned in the bug is not a public class and has no javadoc generated, ignoring that one.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14714/head:pull/14714$ git checkout pull/14714Update a local copy of the PR:
$ git checkout pull/14714$ git pull https://git.openjdk.org/jdk.git pull/14714/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14714View PR using the GUI difftool:
$ git pr show -t 14714Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14714.diff
Webrev
Link to Webrev Comment