Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality #14715

Closed

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Jun 29, 2023

Please review this PR, which clarifies the parameter description of ChoiceFormat.setChoices().

ChoiceFormat.setChoices(double[] limits, String[] formats) claims that formats can either be "Format objects or Strings". It also claims that "When formatting with object Y, if the object is a NumberFormat, then ((NumberFormat) Y).format(X) is called. Otherwise Y.toString() is called".

This is not true as formats is an array of Strings. Thus, the second claim is impossible and unimplemented in the method itself.

The unimplemented specification should be removed from the parameter description.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8311106 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality (Bug - P4)
  • JDK-8311106: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14715/head:pull/14715
$ git checkout pull/14715

Update a local copy of the PR:
$ git checkout pull/14715
$ git pull https://git.openjdk.org/jdk.git pull/14715/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14715

View PR using the GUI difftool:
$ git pr show -t 14715

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14715.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jun 29, 2023
@openjdk
Copy link

openjdk bot commented Jun 29, 2023

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jun 29, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 29, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 11, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 146 new commits pushed to the master branch:

  • 4b1403d: 8311548: AArch64: [ZGC] Many tests fail with "assert(allocates2(pc)) failed: not in CodeBuffer memory" on some CPUs
  • 940a4e1: 8304503: Modernize debugging jvm args in demo netbeans projects
  • 57e7e82: 8309637: runtime/handshake/HandshakeTimeoutTest.java fails with "has not cleared handshake op" and SIGILL
  • 63f32fb: 8311528: Remove IDE specific SuppressWarnings
  • b285ed7: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
  • 6569b25: 8311593: Minor doc issue in MemorySegment::copy
  • 623cfcd: 8310892: ScopedValue throwing StructureViolationException should be clearer
  • 06a1a15: 8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly
  • 581f90e: 8311604: Simplify NOCOOPS requested addresses for archived heap objects
  • 4a1fcb6: 8193513: add support for printing a stack trace on class loading
  • ... and 136 more: https://git.openjdk.org/jdk/compare/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Jul 11, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 11, 2023

Going to push as commit 6cb9ec3.
Since your change was applied there have been 153 commits pushed to the master branch:

  • 401c3de: 8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990
  • e154b0d: 8311606: Change read_icc_profile() to static function in java.desktop/share/native/libjavajpeg/imageioJPEG.c
  • a03a3a4: 8311178: JMH tests don't scale well when sharing output buffers
  • 00c7f91: 8310047: Add UTF-32 based Charsets into StandardCharsets
  • caadad4: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
  • b3f3403: 8311689: Wrong visible amount in Adjustable of ScrollPane
  • a1cfc96: 8311245: JFR: Remove t.printStackTrace() in PeriodicEvents
  • 4b1403d: 8311548: AArch64: [ZGC] Many tests fail with "assert(allocates2(pc)) failed: not in CodeBuffer memory" on some CPUs
  • 940a4e1: 8304503: Modernize debugging jvm args in demo netbeans projects
  • 57e7e82: 8309637: runtime/handshake/HandshakeTimeoutTest.java fails with "has not cleared handshake op" and SIGILL
  • ... and 143 more: https://git.openjdk.org/jdk/compare/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2023
@openjdk openjdk bot closed this Jul 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2023
@openjdk
Copy link

openjdk bot commented Jul 11, 2023

@justin-curtis-lu Pushed as commit 6cb9ec3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
2 participants