-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8311180: Remove unused unneeded definitions from globalDefinitions #14737
Conversation
/contributor add @xmas92 |
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
@coleenp |
Webrevs
|
src/hotspot/cpu/ppc/icache_ppc.hpp
Outdated
@@ -44,7 +44,7 @@ class ICache : public AbstractICache { | |||
static void ppc64_flush_icache_bytes(address start, int bytes) { | |||
// Align start address to an icache line boundary and transform | |||
// nbytes to an icache line count. | |||
const uint line_offset = mask_address_bits(start, line_size - 1); | |||
const uint line_offset = (intptr_t)start & (line_size - 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive by comment: This used to be a uintptr_t
cast, now its intptr_t
- why signed? Was that a deliberate decision?
Side question, I always wondered about the widespread use of intptr_t
in hotspot when casting pointers to integrals, e.g. in p2i()
. Why a signed integer? E.g. if you then use it for bitwise ops (the major reason why one converts a pointer to an int) it seems more hassle to have to remember the rules for using bitwise operators on signed integers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Thomas, thanks for noticing. I messed this one up.
Are you arguing for address_word to avoid this confusion? That's a lot of reeducation in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Coleen, no, I was just wondering if the decision was deliberate. I may have overlooked a reason for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tstuefe p2i()
is mainly used for printing, and the format uses hex so the signed-ness is immaterial. But in general, yes this seems an odd choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay. Thanks
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks for the review David and Axel and finding a bug, Thomas. Maybe p2i should be fixed? |
Going to push as commit 22e17c2.
Your commit was automatically rebased without conflicts. |
I noticed this cleanup in a patch that Axel shared with me that I thought should be pushed on its own as trivial.
Tested with tier1 on Oracle supported platforms and looked for these on the others.
Progress
Issue
Reviewers
Contributors
<aboldtch@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14737/head:pull/14737
$ git checkout pull/14737
Update a local copy of the PR:
$ git checkout pull/14737
$ git pull https://git.openjdk.org/jdk.git pull/14737/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14737
View PR using the GUI difftool:
$ git pr show -t 14737
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14737.diff
Webrev
Link to Webrev Comment