Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311186: ProblemList javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java on linux-aarch64 #14741

Closed
wants to merge 6 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 30, 2023

Trivial ProblemListing/disable changes:

  • JDK-8311186 ProblemList javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java on linux-aarch64
  • JDK-8311189 disable gc/z/TestHighUsage.java
  • JDK-8311190 ProblemList javax/management/remote/mandatory/connection/DeadLockTest.java with virtual threads on windows-x64
  • JDK-8311191 ProblemList javax/management/remote/mandatory/connection/ConnectionTest.java with virtual threads on windows-x64
  • JDK-8311193 ProblemList vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java on linux-all
  • JDK-8311195 ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java with Xcomp on macosx-x64

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8311186: ProblemList javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java on linux-aarch64 (Sub-task - P4)
  • JDK-8311189: disable gc/z/TestHighUsage.java (Sub-task - P4)
  • JDK-8311190: ProblemList javax/management/remote/mandatory/connection/DeadLockTest.java with virtual threads on windows-x64 (Sub-task - P4)
  • JDK-8311191: ProblemList javax/management/remote/mandatory/connection/ConnectionTest.java with virtual threads on windows-x64 (Sub-task - P4)
  • JDK-8311193: ProblemList vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java on linux-all (Sub-task - P4)
  • JDK-8311195: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java with Xcomp on macosx-x64 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14741/head:pull/14741
$ git checkout pull/14741

Update a local copy of the PR:
$ git checkout pull/14741
$ git pull https://git.openjdk.org/jdk.git pull/14741/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14741

View PR using the GUI difftool:
$ git pr show -t 14741

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14741.diff

Webrev

Link to Webrev Comment

…ion/SubjectDelegation1Test.java on linux-aarch64
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk
Copy link
Member Author

/label add serviceability
/label add hotspot-gc

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk
The hotspot-gc label was successfully added.

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8311186
/issue JDK-8311189
/issue JDK-8311190
/issue JDK-8311191
/issue JDK-8311193
/issue JDK-8311195

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8311189: disable gc/z/TestHighUsage.java.

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8311190: ProblemList javax/management/remote/mandatory/connection/DeadLockTest.java with virtual threads on windows-x64.

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8311191: ProblemList javax/management/remote/mandatory/connection/ConnectionTest.java with virtual threads on windows-x64.

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8311193: ProblemList vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java on linux-all.

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8311195: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java with Xcomp on macosx-x64.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review June 30, 2023 21:09
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 30, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2023

Webrevs

Copy link
Member

@lmesnik lmesnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that test/hotspot/jtreg/gc/z/TestHighUsage.java can't be problemlisted using zgc test lists. But why not to put into plain ProblemList.txt?
Also, might be it makes sense to remove it from *zgc problem list while adding ignore? But might be it could be done while fixing bug.

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311186: ProblemList javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java on linux-aarch64
8311189: disable gc/z/TestHighUsage.java
8311190: ProblemList javax/management/remote/mandatory/connection/DeadLockTest.java with virtual threads on windows-x64
8311191: ProblemList javax/management/remote/mandatory/connection/ConnectionTest.java with virtual threads on windows-x64
8311193: ProblemList vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java on linux-all
8311195: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java with Xcomp on macosx-x64

Reviewed-by: lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 971c2ef: 8303086: SIGSEGV in JavaThread::is_interp_only_mode()
  • f6bdccb: 8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 30, 2023
@dcubed-ojdk
Copy link
Member Author

I guess test/hotspot/jtreg/gc/z/TestHighUsage.java could be added to the
ProblemList.txt file. However, that feels a bit misleading to me. It's a
Generational ZGC only test that can't be ProblemListed in the usual way
by putting it on the Generational ZGC ProblemList.

In this case, I just wanted to be sure that it just doesn't run anywhere for
any reason. Especially after the two previous (bad) ProblemListing attempts.

@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

Going to push as commit 140b70f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 971c2ef: 8303086: SIGSEGV in JavaThread::is_interp_only_mode()
  • f6bdccb: 8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 30, 2023
@openjdk openjdk bot closed this Jun 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk Pushed as commit 140b70f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lmesnik
Copy link
Member

lmesnik commented Jun 30, 2023

There is misunderstanding here. Generational ZGC ProblemList is used not to problemlist Gen ZGC tests, but probleml list any test with -XX:ZGC + Generational enabled execution.

@dcubed-ojdk
Copy link
Member Author

And my point is that the test executes only with Generational ZGC and cannot
always be ProblemListed via the ProblemList-generational-zgc.txt file.

The test internally specifies -XX:+UseZGC and -XX:+ZGenerational, but not
in a way where the ProblemList-generational-zgc.txt file comes into play.

@dcubed-ojdk
Copy link
Member Author

/backport jdk21

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@dcubed-ojdk Could not automatically backport 140b70fb to openjdk/jdk21 due to conflicts in the following files:

  • test/jdk/ProblemList-Virtual.txt

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk21. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk21.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b dcubed-ojdk-backport-140b70fb

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 140b70fb29e2b83e5d33765906ee76a36442a687

# Backport the commit
$ git cherry-pick --no-commit 140b70fb29e2b83e5d33765906ee76a36442a687
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 140b70fb29e2b83e5d33765906ee76a36442a687'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk21 with the title Backport 140b70fb29e2b83e5d33765906ee76a36442a687.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8311186 branch July 1, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants