Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8305962: update jcstress to 0.16 #14742

Closed
wants to merge 3 commits into from
Closed

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Jun 30, 2023

The fix changes jcstress version and update some parameters used by the jtreg wrapper.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305962: update jcstress to 0.16 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14742/head:pull/14742
$ git checkout pull/14742

Update a local copy of the PR:
$ git checkout pull/14742
$ git pull https://git.openjdk.org/jdk.git pull/14742/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14742

View PR using the GUI difftool:
$ git pr show -t 14742

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14742.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2023

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@lmesnik To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@lmesnik
Copy link
Member Author

lmesnik commented Jun 30, 2023

/cc hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@lmesnik
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 30, 2023

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually sure if modern jcstress can be executed with this wrapper, given how it might need to drop in JNA blobs before execution.

There is a (not yet released) version of jcstress that gives -tb (time budget) option that might be useful here.

Comment on lines 112 to 114
// The "default" preset might take days for some tests
// so use sanity testing by default.
String mode = "sanity";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sanity mode is incorrect for actual testing runs. Should be at least quick.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines +128 to +129
extraFlags.add("-sc");
extraFlags.add("false");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to shorten the execution time? I'd recommend -af GLOBAL too then, since we are reducing the test matrix for it anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@lmesnik lmesnik changed the title JDK-8305962: update jcstress to 0.17 JDK-8305962: update jcstress to 0.16 Jul 7, 2023
@lmesnik
Copy link
Member Author

lmesnik commented Jul 7, 2023

Aleksey, thank you for for useful comments. Our infra is still required to use jtreg wrapper to run jcstress. I verified that it still work.
We are going to vary stress level in testing (with jtreg factor).

@openjdk
Copy link

openjdk bot commented Jul 7, 2023

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305962: update jcstress to 0.16

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2023
@shipilev
Copy link
Member

shipilev commented Jul 7, 2023

All right then! Talk to me for next jcstress update, you'll need adjustments to these options.

@lmesnik
Copy link
Member Author

lmesnik commented Jul 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 7, 2023

Going to push as commit 292ee63.
Since your change was applied there have been 57 commits pushed to the master branch:

  • 12e9430: 8310818: Refactor more Locale tests to use JUnit
  • 5667afc: 8295068: SSLEngine throws NPE parsing CertificateRequests
  • 34004e1: 8311575: Fix invalid format parameters
  • 9084b6c: 8311514: Incorrect regex in TestMetaSpaceLog.java
  • 0ef03f1: 8311285: report some fontconfig related environment variables in hs_err file
  • 92ca670: 8310170: Use sp's argument to improve performance of outputStream::indent and remove SP_USE_TABS
  • 25cbe85: 8310550: Adjust references to rt.jar
  • 848abd2: 8311511: Improve description of NativeLibrary JFR event
  • 6485b7d: 6875229: Wrong placement of icons in JTabbedPane in Nimbus
  • 27de536: 8311581: Remove obsolete code and comments in TestLVT.java
  • ... and 47 more: https://git.openjdk.org/jdk/compare/19601ebe9192773a1a47ec3e003b9f1a6808d3de...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 7, 2023
@openjdk openjdk bot closed this Jul 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 7, 2023
@openjdk
Copy link

openjdk bot commented Jul 7, 2023

@lmesnik Pushed as commit 292ee63.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
2 participants