8311245: JFR: Remove t.printStackTrace() in PeriodicEvents

[egahlin]

Could I have review of a fix that removes a debug statement.

Testing: test/jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311245: JFR: Remove t.printStackTrace() in PeriodicEvents (Bug - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14754/head:pull/14754
$ git checkout pull/14754

Update a local copy of the PR:
$ git checkout pull/14754
$ git pull https://git.openjdk.org/jdk.git pull/14754/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14754

View PR using the GUI difftool:
$ git pr show -t 14754

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14754.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f2eb519c)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311245: JFR: Remove t.printStackTrace() in PeriodicEvents

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• 4b1403d: 8311548: AArch64: [ZGC] Many tests fail with "assert(allocates2(pc)) failed: not in CodeBuffer memory" on some CPUs
• 940a4e1: 8304503: Modernize debugging jvm args in demo netbeans projects
• 57e7e82: 8309637: runtime/handshake/HandshakeTimeoutTest.java fails with "has not cleared handshake op" and SIGILL
• 63f32fb: 8311528: Remove IDE specific SuppressWarnings
• b285ed7: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
• 6569b25: 8311593: Minor doc issue in MemorySegment::copy
• 623cfcd: 8310892: ScopedValue throwing StructureViolationException should be clearer
• 06a1a15: 8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly
• 581f90e: 8311604: Simplify NOCOOPS requested addresses for archived heap objects
• 4a1fcb6: 8193513: add support for printing a stack trace on class loading
• ... and 39 more: https://git.openjdk.org/jdk/compare/f393975d1b9423835a7aa42f6ffc0656499701d7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit a1cfc96.
Since your change was applied there have been 49 commits pushed to the master branch:

• 4b1403d: 8311548: AArch64: [ZGC] Many tests fail with "assert(allocates2(pc)) failed: not in CodeBuffer memory" on some CPUs
• 940a4e1: 8304503: Modernize debugging jvm args in demo netbeans projects
• 57e7e82: 8309637: runtime/handshake/HandshakeTimeoutTest.java fails with "has not cleared handshake op" and SIGILL
• 63f32fb: 8311528: Remove IDE specific SuppressWarnings
• b285ed7: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
• 6569b25: 8311593: Minor doc issue in MemorySegment::copy
• 623cfcd: 8310892: ScopedValue throwing StructureViolationException should be clearer
• 06a1a15: 8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly
• 581f90e: 8311604: Simplify NOCOOPS requested addresses for archived heap objects
• 4a1fcb6: 8193513: add support for printing a stack trace on class loading
• ... and 39 more: https://git.openjdk.org/jdk/compare/f393975d1b9423835a7aa42f6ffc0656499701d7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit a1cfc96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[egahlin]

/backport jdk21

[openjdk]

@egahlin the backport was successfully created on the branch egahlin-backport-a1cfc969 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit a1cfc969 from the openjdk/jdk repository.

The commit being backported was authored by Erik Gahlin on 11 Jul 2023 and was reviewed by Markus Grönlund.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git egahlin-backport-a1cfc969:egahlin-backport-a1cfc969
$ git checkout egahlin-backport-a1cfc969
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git egahlin-backport-a1cfc969