Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318983: Fix comment typo in PKCS12Passwd.java #14762

Closed
wants to merge 1 commit into from
Closed

8318983: Fix comment typo in PKCS12Passwd.java #14762

wants to merge 1 commit into from

Conversation

gnp
Copy link
Contributor

@gnp gnp commented Jul 3, 2023


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318983: Fix comment typo in PKCS12Passwd.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14762/head:pull/14762
$ git checkout pull/14762

Update a local copy of the PR:
$ git checkout pull/14762
$ git pull https://git.openjdk.org/jdk.git pull/14762/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14762

View PR using the GUI difftool:
$ git pr show -t 14762

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14762.diff

Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jul 3, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 3, 2023

Hi @gnp, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user gnp" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jul 3, 2023

@gnp The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jul 3, 2023
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Jul 10, 2023
@gnp
Copy link
Contributor Author

gnp commented Jul 26, 2023

/signed

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2023

You are already a known contributor!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2023

@gnp This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@gnp
Copy link
Contributor Author

gnp commented Sep 4, 2023

I tried filing an issue to reference but could not.

Could someone please help get this PR merged?

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2023

@gnp This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@gnp
Copy link
Contributor Author

gnp commented Oct 3, 2023

Could someone with the ability to file an issue or bypass that requirement please help?

@mdinacci @hns @landonf @joebowbeer

@wangweij
Copy link
Contributor

Sorry about not noticing this earlier. I've filed https://bugs.openjdk.org/browse/JDK-8318983. Please update the PR title.

@gnp gnp changed the title Fix comment typo in PKCS12Passwd.java Fix comment typo in PKCS12Passwd.java; FIXES: JDK-8318983 Oct 27, 2023
@gnp
Copy link
Contributor Author

gnp commented Oct 27, 2023

Sorry about not noticing this earlier. I've filed https://bugs.openjdk.org/browse/JDK-8318983. Please update the PR title.

Thanks @wangweij! I added a suffix "; FIXES: JDK-8318983" to the title. Hope that helps.

@wangweij
Copy link
Contributor

wangweij commented Oct 27, 2023

Thanks for coming back! The jcheck failure abovebelow suggests you rewrite the title to something like "8318983: Fix comment typo in PKCS12Passwd.java". You can also read the title of other PRs as examples.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2023

@gnp This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@gnp gnp changed the title Fix comment typo in PKCS12Passwd.java; FIXES: JDK-8318983 8318983: Fix comment typo in PKCS12Passwd.java Dec 2, 2023
@gnp
Copy link
Contributor Author

gnp commented Dec 2, 2023

Fixed the title of the PR

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 2, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2023

Webrevs

Copy link
Contributor

@wangweij wangweij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. You can type the /integrate command now.

@openjdk
Copy link

openjdk bot commented Dec 2, 2023

@gnp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318983: Fix comment typo in PKCS12Passwd.java

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1858 new commits pushed to the master branch:

  • 4dcbd13: 8314905: jdk/jfr/tool/TestView.java fails with RuntimeException 'Invoked Concurrent' missing from stdout/stderr
  • 5dee2a3: 8320440: Implementation of Structured Concurrency (Second Preview)
  • 6f7bb79: 8320931: [REDO] dsymutil command leaves around temporary directories
  • 8be3e39: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • 2f299e4: 8321182: SourceExample.SOURCE_14 comment should refer to 'switch expressions' instead of 'text blocks'
  • 3a09a05: 8313722: JFR: Avoid unnecessary calls to Events.from(Recording)
  • 42af8ce: 8308614: Enabling JVMTI ClassLoad event slows down vthread creation by factor 10
  • 1839433: 8320941: Discuss receiver type handling
  • 92f7e51: 8312098: Update man page for javadoc
  • f6be7fd: 8321059: Unneeded array assignments in MergeCollation and CompactByteArray
  • ... and 1848 more: https://git.openjdk.org/jdk/compare/b9198f993173b0fbdc7ff1400e2205d3969370da...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 2, 2023
@gnp
Copy link
Contributor Author

gnp commented Dec 2, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 2, 2023
@openjdk
Copy link

openjdk bot commented Dec 2, 2023

@gnp
Your change (at version 2dc3454) is now ready to be sponsored by a Committer.

@gnp
Copy link
Contributor Author

gnp commented Dec 2, 2023

Thanks @wangweij could you please sponsor?

@wangweij
Copy link
Contributor

wangweij commented Dec 2, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 2, 2023

Going to push as commit 9498469.
Since your change was applied there have been 1858 commits pushed to the master branch:

  • 4dcbd13: 8314905: jdk/jfr/tool/TestView.java fails with RuntimeException 'Invoked Concurrent' missing from stdout/stderr
  • 5dee2a3: 8320440: Implementation of Structured Concurrency (Second Preview)
  • 6f7bb79: 8320931: [REDO] dsymutil command leaves around temporary directories
  • 8be3e39: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • 2f299e4: 8321182: SourceExample.SOURCE_14 comment should refer to 'switch expressions' instead of 'text blocks'
  • 3a09a05: 8313722: JFR: Avoid unnecessary calls to Events.from(Recording)
  • 42af8ce: 8308614: Enabling JVMTI ClassLoad event slows down vthread creation by factor 10
  • 1839433: 8320941: Discuss receiver type handling
  • 92f7e51: 8312098: Update man page for javadoc
  • f6be7fd: 8321059: Unneeded array assignments in MergeCollation and CompactByteArray
  • ... and 1848 more: https://git.openjdk.org/jdk/compare/b9198f993173b0fbdc7ff1400e2205d3969370da...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 2, 2023
@openjdk openjdk bot closed this Dec 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 2, 2023
@openjdk
Copy link

openjdk bot commented Dec 2, 2023

@wangweij @gnp Pushed as commit 9498469.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gnp gnp deleted the patch-1 branch December 2, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants