8311023: assert(false) failed: EA: missing memory path

[jatin-bhateja]

Handling missing cases for VectorizedHashCode while collecting memory nodes for propagating new type information through the graph.

We associate new instance types with CheckCastPP nodes succeeding allocation IR, refresh connectivity of MemoryMerge slices at alias indices corresponding to new instance type and update the memory edges of user memory nodes in the ideal graph to ease out scalar replacements.

Please review and share feedback.

Best Regards,
Jatin

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311023: assert(false) failed: EA: missing memory path (Bug - P3)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer) ⚠️ Review applies to 75e1642f
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14764/head:pull/14764
$ git checkout pull/14764

Update a local copy of the PR:
$ git checkout pull/14764
$ git pull https://git.openjdk.org/jdk.git pull/14764/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14764

View PR using the GUI difftool:
$ git pr show -t 14764

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14764.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jatin-bhateja The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[jatin-bhateja]

/label add hotspot-compiler-dev

[openjdk]

@jatin-bhateja The hotspot-compiler label was already applied.

[mlbridge]

Webrevs

• 02: Full - Incremental (344fdf9b)
• 01: Full - Incremental (d56563ff)
• 00: Full (75e1642f)

[TobiHartmann]

Looks good to me. Please change the test name to something more descriptive.

[openjdk]

@jatin-bhateja This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311023: assert(false) failed: EA: missing memory path

Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[chhagedorn]

Looks good!

[jatin-bhateja]

Thanks @chhagedorn , @TobiHartmann

[jatin-bhateja]

/integrate

[openjdk]

Going to push as commit 6ebb0e3.
Since your change was applied there have been 4 commits pushed to the master branch:

• 2cffef2: 8311290: Improve java.lang.ref.Cleaner rendered documentation
• 22e17c2: 8311180: Remove unused unneeded definitions from globalDefinitions
• cf82e31: 8311077: Fix -Wconversion warnings in jvmti code
• 00ac46c: 8310645: CancelledResponse.java does not use HTTP/2 when testing the HttpClient

Your commit was automatically rebased without conflicts.

[openjdk]

@jatin-bhateja Pushed as commit 6ebb0e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.