Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8311511: Improve description of NativeLibrary JFR event #14774

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 5, 2023

The JFR NativeLibrary event description should be improved.
Currently there is no description at all, but there should be one indicating that 'NativeLibrary' can be different kinds of native images. For example on macOS the frameworks show up. On AIX, java itself or some mapped files show up too in the list.

On macOS the 'Top Address' is currently always 0 (info not available) . So give some hint in the description that this can happen.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311511: Improve description of NativeLibrary JFR event (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14774/head:pull/14774
$ git checkout pull/14774

Update a local copy of the PR:
$ git checkout pull/14774
$ git pull https://git.openjdk.org/jdk.git pull/14774/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14774

View PR using the GUI difftool:
$ git pr show -t 14774

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14774.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jul 5, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2023

Webrevs

@parttimenerd
Copy link
Contributor

Thank you for the improved description, I hope it's not the last :)

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Jul 6, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311511: Improve description of NativeLibrary JFR event

Reviewed-by: clanger, jbechberger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 7173c30: 8307766: Linux: Provide the option to override the timer slack
  • 356067d: 8311489: Remove unused dirent_md files
  • 3d813ae: 8311301: MethodExitTest may fail with stack buffer overrun
  • 0741cd3: 8311264: JavaDoc index comparator is not transitive
  • edb2be1: 8311279: TestStressIGVNAndCCP.java failed with different IGVN traces for the same seed
  • d072c40: 8311183: Remove unused mapping test files
  • 66d2736: 8307526: [JFR] Better handling of tampered JFR repository
  • 0616648: 8311035: CDS should not use dump time JVM narrow Klass encoding to pre-compute Klass ids
  • 6eba096: 8310999: Add @SInCE info in jdk.jsobject files
  • 6ebb0e3: 8311023: assert(false) failed: EA: missing memory path

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 6, 2023
@MBaesken
Copy link
Member Author

MBaesken commented Jul 7, 2023

Hi Christoph and Johannes, thanks for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 7, 2023

Going to push as commit 848abd2.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 6485b7d: 6875229: Wrong placement of icons in JTabbedPane in Nimbus
  • 27de536: 8311581: Remove obsolete code and comments in TestLVT.java
  • e848d94: 8310923: Refactor Currency tests to use JUnit
  • 0c86c31: 8302351: "assert(!JavaThread::current()->is_interp_only_mode() || !nm->method()->is_continuation_enter_intrinsic() || ContinuationEntry::is_interpreted_call(return_pc)) failed: interp_only_mode but not in enterSpecial interpreted entry" in fixup_callers_callsite
  • ec7da91: 8240567: MethodTooLargeException thrown while creating a jlink image
  • 97e99f0: 8311087: PhiNode::wait_for_region_igvn should break early
  • 7173c30: 8307766: Linux: Provide the option to override the timer slack
  • 356067d: 8311489: Remove unused dirent_md files
  • 3d813ae: 8311301: MethodExitTest may fail with stack buffer overrun
  • 0741cd3: 8311264: JavaDoc index comparator is not transitive
  • ... and 6 more: https://git.openjdk.org/jdk/compare/2cffef21201c3e8be87c92234712839bff531047...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 7, 2023
@openjdk openjdk bot closed this Jul 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 7, 2023
@openjdk
Copy link

openjdk bot commented Jul 7, 2023

@MBaesken Pushed as commit 848abd2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
3 participants