Skip to content

8310999: Add @since info in jdk.jsobject files #14775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Jul 5, 2023

Source code cleanup.
Add @SInCE, remove unused imports and remove unnecessary SuppressWarnings of deprecation.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14775/head:pull/14775
$ git checkout pull/14775

Update a local copy of the PR:
$ git checkout pull/14775
$ git pull https://git.openjdk.org/jdk.git pull/14775/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14775

View PR using the GUI difftool:
$ git pr show -t 14775

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14775.diff

Webrev

Link to Webrev Comment

Add @SInCE, remove unused imports and remove unnecessary SuppressWarnings of deprecation.
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2023

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@RogerRiggs To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@RogerRiggs
Copy link
Contributor Author

/label core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@RogerRiggs
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 5, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310999: Add @since info in jdk.jsobject files

Reviewed-by: lancea, joehw, bpb, iris, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 5, 2023
Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless my eyes deceive me the suppresswarnings is still present.

@RogerRiggs
Copy link
Contributor Author

unless my eyes deceive me the suppresswarnings is still present.

Gack!, I removed it and then put it back to try to discover why it was there in the first place.
Gone again and thanks

@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2023

Going to push as commit 6eba096.
Since your change was applied there have been 32 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2023
@openjdk openjdk bot closed this Jul 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@RogerRiggs Pushed as commit 6eba096.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8310999-jsobject-since branch December 11, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

6 participants