8252882: Clean up jdk.javadoc and the related parts of jdk.compiler #148
Conversation
…oops. Those conditions guard against infinite loops. Perhaps in the future we should use `boolean notEOF() { return bp < buflen; }` instead. The only naked `while` loop left is in `erroneous(...)`; that method needs to be revisited anyway. I suspect it's not rolling back correctly.
2. Added several assisting `assert` statements.
3. FQNs for `java.util.List` and `javax.lang.model.element.Name` were dropped (those are covered by the *existing* imports).
4. The result of `splitBody(fullBody)` is not used, and the call doesn't seem to have side effects. Furthermore, it is called inside `newDocCommentTree`.
5. Got rid of some casts by using a more specific type in `com.sun.tools.javac.parser.DocCommentParser.inlineText`
|
👋 Welcome back prappo! A progress list of the required criteria for merging this PR into |
|
@pavelrappo The following labels will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the |
openjdk
bot
added
javadoc
Webrevs
|
|
/test tier1 tier2 tier3 |
|
@pavelrappo the test group tier1 tier2 tier3 does not exist |
|
/test tier1 |
|
A test job has been started with id: github.com-149121954-148-691942047 |
|
@pavelrappo your test job with id github.com-149121954-148-691942047 for commits up until acb118a has finished. |
src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
Outdated
Show resolved
Hide resolved
|
Mailing list message from Jonathan Gibbons on compiler-dev: On 9/14/20 7:11 AM, Pavel Rappo wrote:
Assert/assert in all its forms should only be used to assert that our As Jan explained at one point, the use of the Assert class is to better -- Jon |
…ntroduced earlier.
|
/test tier1 |
|
A test job has been started with id: github.com-149121954-148-692159993 |
|
@pavelrappo This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 57 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
|
@pavelrappo your test job with id github.com-149121954-148-692159993 for commits up until 67fa917 has finished. |
|
/integrate |
openjdk
bot
added
integrated
|
@pavelrappo Since your change was applied there have been 57 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e6a493a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
…5a69045d5b1cb3468f24ff6 [Snyk] Upgrade org.jboss.openjdk-orb:openjdk-orb from 8.1.4.Final to 8.1.9.Final
Yet another cleanup change that has accumulated during my work on
DocCommentParserand other javadoc-related areas of compiler.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/148/head:pull/148$ git checkout pull/148