Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311081: KeytoolReaderP12Test.java fail on localized Windows platform #14806

Closed
wants to merge 3 commits into from

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Jul 7, 2023

Please review this PR which addresses KeytoolReaderP12Test.java failing for non-English locale users.

This test checks output from keytool, but fails on finding the value 'alias name' for non-English locale users. This is because 'alias name' is a localized value. (For example, in ja this is '別名').

To fix the failing issue, the keytool process should be ran with -J-Duser.language=en -J-Duser.country=US.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311081: KeytoolReaderP12Test.java fail on localized Windows platform (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14806/head:pull/14806
$ git checkout pull/14806

Update a local copy of the PR:
$ git checkout pull/14806
$ git pull https://git.openjdk.org/jdk.git pull/14806/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14806

View PR using the GUI difftool:
$ git pr show -t 14806

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14806.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 7, 2023
@openjdk
Copy link

openjdk bot commented Jul 7, 2023

@justin-curtis-lu The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jul 7, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2023

Webrevs

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, you are probably going to need to add the noreg-self label to the bug

@openjdk
Copy link

openjdk bot commented Jul 7, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311081: KeytoolReaderP12Test.java fail on localized Windows platform

Reviewed-by: lancea, jpai, weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 673 new commits pushed to the master branch:

  • 99ea8bf: 8315062: [GHA] get-bootjdk action should return the abolute path
  • acb24bf: 8315116: fix minor issue in copyright header introduced by JDK-8269957 that is breaking the build
  • 11da15d: 8269957: facilitate alternate impls of NameTable and Name
  • 725ec0c: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • 1c3177e: 8315029: [BACKOUT] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • dd23f7d: 8315039: Parallel: Remove unimplemented PSYoungGen::oop_iterate
  • 5c4f1dc: 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake
  • cf2d33c: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • 1664e79: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations
  • 0901d75: 8314762: Make {@Incubating} conventional
  • ... and 663 more: https://git.openjdk.org/jdk/compare/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2023
@justin-curtis-lu
Copy link
Member Author

I have updated the fix so that executeKeytoolCommand() itself always sets the English locale params, as executeKeytoolCommand() is not used in any sort of intentional localized testing.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 10, 2023

@justin-curtis-lu This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 28, 2023

Going to push as commit b4b2fec.
Since your change was applied there have been 675 commits pushed to the master branch:

  • 31e2681: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
  • 21916f3: 8139208: [macosx] Issue with setExtendedState of JFrame
  • 99ea8bf: 8315062: [GHA] get-bootjdk action should return the abolute path
  • acb24bf: 8315116: fix minor issue in copyright header introduced by JDK-8269957 that is breaking the build
  • 11da15d: 8269957: facilitate alternate impls of NameTable and Name
  • 725ec0c: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • 1c3177e: 8315029: [BACKOUT] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • dd23f7d: 8315039: Parallel: Remove unimplemented PSYoungGen::oop_iterate
  • 5c4f1dc: 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake
  • cf2d33c: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • ... and 665 more: https://git.openjdk.org/jdk/compare/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 28, 2023
@openjdk openjdk bot closed this Aug 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 28, 2023
@openjdk
Copy link

openjdk bot commented Aug 28, 2023

@justin-curtis-lu Pushed as commit b4b2fec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
4 participants