8311666: Disabled tests in test/jdk/sun/java2d/marlin

[cushon]

Please review this fix for JDK-8311666, which adds missing jtreg /* @test */ comments to several tests in test/jdk/sun/java2d/marlin which were not being run.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311666: Disabled tests in test/jdk/sun/java2d/marlin (Bug - P3)

Reviewers

• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14807/head:pull/14807
$ git checkout pull/14807

Update a local copy of the PR:
$ git checkout pull/14807
$ git pull https://git.openjdk.org/jdk.git pull/14807/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14807

View PR using the GUI difftool:
$ git pr show -t 14807

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14807.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cushon The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6c0c7865)

[prrace]

Hmm. Puzzling.
These tests seem to have been like this since (at least) JDK8u days.
I don't understand how they managed to be updated several times over the years without anyone addressing this. I hope I'm not missing something but they have no comment to explain it.
And they do pass for me on current JDK.
But best to push this on Monday not Friday in case there is a surprise.

[openjdk]

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311666: Disabled tests in test/jdk/sun/java2d/marlin

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 4a1fcb6: 8193513: add support for printing a stack trace on class loading

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[cushon]

Thanks for taking a look!

Hmm. Puzzling. These tests seem to have been like this since (at least) JDK8u days. I don't understand how they managed to be updated several times over the years without anyone addressing this. I hope I'm not missing something but they have no comment to explain it. And they do pass for me on current JDK. But best to push this on Monday not Friday in case there is a surprise.

I think that matches my understanding, that it was an oversight when they were originally contributed, and then it went unnoticed and unfixed since then.

Submitting earlier in the week sounds good to me.

[bourgesl]

The test dates are from 2010 for pisces, moved into marlin tests once pisces was removed in 2017.
LGTM

[mlbridge]

Mailing list message from Patrick Chen on client-libs-dev:

Fy

Le sam. 8 juil. 2023, 11:13, Laurent Bourg?s <lbourges at openjdk.org> a
?crit :

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20230708/872166b2/attachment-0001.htm>

[cushon]

/integrate

[openjdk]

Going to push as commit b285ed7.
Since your change was applied there have been 5 commits pushed to the master branch:

• 6569b25: 8311593: Minor doc issue in MemorySegment::copy
• 623cfcd: 8310892: ScopedValue throwing StructureViolationException should be clearer
• 06a1a15: 8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly
• 581f90e: 8311604: Simplify NOCOOPS requested addresses for archived heap objects
• 4a1fcb6: 8193513: add support for printing a stack trace on class loading

Your commit was automatically rebased without conflicts.

[openjdk]

@cushon Pushed as commit b285ed7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.