Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248736: [aarch64] runtime/signal/TestSigpoll.java failed "fatal error: not an ldr (literal) instruction." #1481

Closed
wants to merge 1 commit into from

Conversation

@stooart-mon
Copy link
Contributor

@stooart-mon stooart-mon commented Nov 27, 2020

Change mov to movptr in the nmethod entry barrier. movptr will generate a consistent number of mov/movk instructions that are necessary to consistently calculate the size of the nmethod barrier.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248736: [aarch64] runtime/signal/TestSigpoll.java failed "fatal error: not an ldr (literal) instruction."

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1481/head:pull/1481
$ git checkout pull/1481

Change mov to movptr in the nmethod entry barrier. movptr will generate
a consistent number of mov/movk instructions that are necessary to
consistently calculate the size of the nmethod barrier.

TEST_LABEL: ent-arch-aarch64
TEST_SCOPE: tier1

Change-Id: I892580dc15d84164b120fbe2b4179647dc02a28a
CustomizedGitHooks: yes
Jira: ENTLLT-3529
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 27, 2020

👋 Welcome back smonteith! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Nov 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

@stooart-mon The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot label Nov 27, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 27, 2020

Webrevs

Loading

@stooart-mon
Copy link
Contributor Author

@stooart-mon stooart-mon commented Dec 1, 2020

You raised the bug @dcubed-ojdk , could you review this please?

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 2, 2020

Mailing list message from David Holmes on hotspot-dev:

Hi Stuart,

On 2/12/2020 4:27 am, Stuart Monteith wrote:

On Fri, 27 Nov 2020 15:11:18 GMT, Stuart Monteith <smonteith at openjdk.org> wrote:

Change mov to movptr in the nmethod entry barrier. movptr will generate a consistent number of mov/movk instructions that are necessary to consistently calculate the size of the nmethod barrier.

You raised the bug @dcubed-ojdk , could you review this please?

Please note that filing a bug has no bearing on reviewing a PR. We have
numerous folk who monitor our testing and will file bugs on failures.

You need theRealAph and shipilev to finalize their reviews.

Cheers,
David

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2020

@stooart-mon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8248736: [aarch64] runtime/signal/TestSigpoll.java failed "fatal error: not an ldr (literal) instruction."

Reviewed-by: aph, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 75 new commits pushed to the master branch:

  • e7ca0c4: 8257224: JDK-8251549 didn't update building.html
  • 7e37c7c: 8257471: fatal error: Fatal exception in JVMCI: Exception during JVMCI compiler initialization
  • 3e3745c: 8256008: UL does not report anything if disk writing fails
  • fb139cf: 8257467: [TESTBUG] -Wdeprecated-declarations is reported at sigset() in exesigtest.c
  • 9de283b: 8257505: nsk/share/test/StressOptions stressTime is scaled in getter but not when printed
  • 282cb32: 8005970: Mouse cursor is default cursor over TextArea's scrollbar
  • f2a0988: 8257228: G1: SIGFPE in G1ConcurrentRefine::create(int*) due to buffers_to_cards overflow
  • fe5cccc: 8254631: Better support ALPN byte wire values in SunJSSE
  • 541c7f7: 8257434: jpackage fails to create rpm on Fedora Linux
  • 8f4fa3f: 8257232: CompileThresholdScaling fails to work on 32-bit platforms
  • ... and 65 more: https://git.openjdk.java.net/jdk/compare/78fdb65dcf61c28c9acb69de7199023f13405639...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Dec 2, 2020
@stooart-mon
Copy link
Contributor Author

@stooart-mon stooart-mon commented Dec 2, 2020

/integrate

Loading

@openjdk openjdk bot added the sponsor label Dec 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2020

@stooart-mon
Your change (at version 725c9b5) is now ready to be sponsored by a Committer.

Loading

@shipilev
Copy link
Contributor

@shipilev shipilev commented Dec 2, 2020

/sponsor

Loading

@openjdk openjdk bot closed this Dec 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2020

@shipilev @stooart-mon Since your change was applied there have been 75 commits pushed to the master branch:

  • e7ca0c4: 8257224: JDK-8251549 didn't update building.html
  • 7e37c7c: 8257471: fatal error: Fatal exception in JVMCI: Exception during JVMCI compiler initialization
  • 3e3745c: 8256008: UL does not report anything if disk writing fails
  • fb139cf: 8257467: [TESTBUG] -Wdeprecated-declarations is reported at sigset() in exesigtest.c
  • 9de283b: 8257505: nsk/share/test/StressOptions stressTime is scaled in getter but not when printed
  • 282cb32: 8005970: Mouse cursor is default cursor over TextArea's scrollbar
  • f2a0988: 8257228: G1: SIGFPE in G1ConcurrentRefine::create(int*) due to buffers_to_cards overflow
  • fe5cccc: 8254631: Better support ALPN byte wire values in SunJSSE
  • 541c7f7: 8257434: jpackage fails to create rpm on Fedora Linux
  • 8f4fa3f: 8257232: CompileThresholdScaling fails to work on 32-bit platforms
  • ... and 65 more: https://git.openjdk.java.net/jdk/compare/78fdb65dcf61c28c9acb69de7199023f13405639...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9a60413.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@openjdk openjdk bot removed the rfr label Dec 2, 2020
@stooart-mon
Copy link
Contributor Author

@stooart-mon stooart-mon commented Dec 2, 2020

Thanks for your reviews @shipilev , @theRealAph!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants