Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311593: Minor doc issue in MemorySegment::copy #14813

Closed
wants to merge 1 commit into from

Conversation

mcimadamore
Copy link
Contributor

@mcimadamore mcimadamore commented Jul 10, 2023

This simple PR fixes an issue where this segment was used in the javadoc of two static methods.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311593: Minor doc issue in MemorySegment::copy (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14813/head:pull/14813
$ git checkout pull/14813

Update a local copy of the PR:
$ git checkout pull/14813
$ git pull https://git.openjdk.org/jdk.git pull/14813/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14813

View PR using the GUI difftool:
$ git pr show -t 14813

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14813.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2023

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 10, 2023
@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@mcimadamore The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 10, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311593: Minor doc issue in MemorySegment::copy

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 623cfcd: 8310892: ScopedValue throwing StructureViolationException should be clearer

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 10, 2023
@mcimadamore
Copy link
Contributor Author

/integrate

@mcimadamore
Copy link
Contributor Author

/backport jdk21

@openjdk
Copy link

openjdk bot commented Jul 10, 2023

Going to push as commit 6569b25.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 623cfcd: 8310892: ScopedValue throwing StructureViolationException should be clearer

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 10, 2023
@openjdk openjdk bot closed this Jul 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2023
@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@mcimadamore Pushed as commit 6569b25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@mcimadamore the backport was successfully created on the branch mcimadamore-backport-6569b252 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6569b252 from the openjdk/jdk repository.

The commit being backported was authored by Maurizio Cimadamore on 10 Jul 2023 and was reviewed by Jorn Vernee.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git mcimadamore-backport-6569b252:mcimadamore-backport-6569b252
$ git checkout mcimadamore-backport-6569b252
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git mcimadamore-backport-6569b252

@mcimadamore
Copy link
Contributor Author

/backport jdk21

@openjdk
Copy link

openjdk bot commented Jul 11, 2023

@mcimadamore the backport was successfully created on the branch mcimadamore-backport-6569b252 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6569b252 from the openjdk/jdk repository.

The commit being backported was authored by Maurizio Cimadamore on 10 Jul 2023 and was reviewed by Jorn Vernee.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git mcimadamore-backport-6569b252:mcimadamore-backport-6569b252
$ git checkout mcimadamore-backport-6569b252
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git mcimadamore-backport-6569b252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants