8311656: Shenandoah: Unused ShenandoahSATBAndRemarkThreadsClosure::_claim_token

[chadrako]

JDK-8311656

Remove unused _claim_token field from ShenandoahSATBAndRemarkThreadsClosure

Additional testing:

• Linux x86_64 fastdebug tier2
• Linux x86_64 release tier2
• Linux x86_64 fastdebug test/hotspot/jtreg/gc/shenandoah
• Linux x86_64 release test/hotspot/jtreg/gc/shenandoah
• Linux x86_64 fastdebug gtest:all
• Linux x86_64 release gtest:all

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311656: Shenandoah: Unused ShenandoahSATBAndRemarkThreadsClosure::_claim_token (Enhancement - P4)

Reviewers

• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14818/head:pull/14818
$ git checkout pull/14818

Update a local copy of the PR:
$ git checkout pull/14818
$ git pull https://git.openjdk.org/jdk.git pull/14818/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14818

View PR using the GUI difftool:
$ git pr show -t 14818

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14818.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chadrako! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chadrako The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (dcf5bd49)

[ysramakrishna]

LGTM!

[openjdk]

@chadrako This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311656: Shenandoah: Unused ShenandoahSATBAndRemarkThreadsClosure::_claim_token

Reviewed-by: ysr, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• fd7fddb: 8295894: Remove SECOM certificate that is expiring in September 2023
• d82ade3: 8310683: Refactor StandardCharset/standard.java to use JUnit
• aac903d: 8311805: Clean up ScrollPane: drop redundant initialiser, mark scroller final
• 15195e6: 8310066: Improve test coverage for JVMTI GetThreadState on carrier and mounted vthread
• 6cb9ec3: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality
• 401c3de: 8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990
• e154b0d: 8311606: Change read_icc_profile() to static function in java.desktop/share/native/libjavajpeg/imageioJPEG.c
• a03a3a4: 8311178: JMH tests don't scale well when sharing output buffers
• 00c7f91: 8310047: Add UTF-32 based Charsets into StandardCharsets
• caadad4: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
• ... and 6 more: https://git.openjdk.org/jdk/compare/b285ed72aebe2d802fa9c071372cea6c09870b9a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@ysramakrishna, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[chadrako]

/integrate

[openjdk]

@chadrako
Your change (at version dcf5bd4) is now ready to be sponsored by a Committer.

[shipilev]

Looks good!

[shipilev]

/sponsor

[openjdk]

Going to push as commit 0b0e064.
Since your change was applied there have been 16 commits pushed to the master branch:

• fd7fddb: 8295894: Remove SECOM certificate that is expiring in September 2023
• d82ade3: 8310683: Refactor StandardCharset/standard.java to use JUnit
• aac903d: 8311805: Clean up ScrollPane: drop redundant initialiser, mark scroller final
• 15195e6: 8310066: Improve test coverage for JVMTI GetThreadState on carrier and mounted vthread
• 6cb9ec3: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality
• 401c3de: 8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990
• e154b0d: 8311606: Change read_icc_profile() to static function in java.desktop/share/native/libjavajpeg/imageioJPEG.c
• a03a3a4: 8311178: JMH tests don't scale well when sharing output buffers
• 00c7f91: 8310047: Add UTF-32 based Charsets into StandardCharsets
• caadad4: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
• ... and 6 more: https://git.openjdk.org/jdk/compare/b285ed72aebe2d802fa9c071372cea6c09870b9a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @chadrako Pushed as commit 0b0e064.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.