Skip to content

JDK-8249836 java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

mahendrachhipa
Copy link
Member

@mahendrachhipa mahendrachhipa commented Nov 27, 2020

…id as 1st word in @ignore

https://bugs.openjdk.java.net/browse/JDK-8249836


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8249836: java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1482/head:pull/1482
$ git checkout pull/1482

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 27, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2020

Hi @mahendrachhipa, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user mahendrachhipa" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2020

@mahendrachhipa The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 27, 2020
@openjdk
Copy link

openjdk bot commented Nov 27, 2020

⚠️ @mahendrachhipa This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@mahendrachhipa mahendrachhipa changed the title JDK-8249836 java/io/IOException/LastErrorString.java should have bug-… Merge JDK:Master Nov 27, 2020
@mahendrachhipa mahendrachhipa changed the title Merge JDK:Master JDK-8249836 java/io/IOException/LastErrorString.java should have b42ee3e bug-id as 1st word in @ignore Nov 27, 2020
@mahendrachhipa mahendrachhipa changed the title JDK-8249836 java/io/IOException/LastErrorString.java should have b42ee3e bug-id as 1st word in @ignore JDK-8249836 java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore Nov 27, 2020
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Nov 27, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2020

Webrevs

Copy link
Member

@iignatev iignatev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Nov 30, 2020

@mahendrachhipa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8249836: java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore

Reviewed-by: iignatyev

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 296 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iignatev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 30, 2020
JDK-8249836 ava/io/IOException/LastErrorString.java should have
bug-id as 1st word in @ignore
https://bugs.openjdk.java.net/browse/JDK-8249836
Merge branch 'JDK-8249836' of https://github.com/mahendrachhipa/jdk into JDK-8249836
@mahendrachhipa
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 1, 2020
@openjdk
Copy link

openjdk bot commented Dec 1, 2020

@mahendrachhipa
Your change (at version d744ec0) is now ready to be sponsored by a Committer.

@iignatev
Copy link
Member

iignatev commented Dec 1, 2020

/sponsor

@openjdk openjdk bot closed this Dec 1, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2020
@openjdk
Copy link

openjdk bot commented Dec 1, 2020

@iignatev @mahendrachhipa Since your change was applied there have been 296 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit c859fb0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants