Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time #14844

Closed
wants to merge 7 commits into from
Closed

8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time #14844

wants to merge 7 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jul 12, 2023 •
edited by openjdk bot
Loading

Due to some threading issues, Progress Monitor is not shown in macos..
Seems like we need to call ProgressMonitor swing component in EDT..

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14844/head:pull/14844
$ git checkout pull/14844

Update a local copy of the PR:
$ git checkout pull/14844
$ git pull https://git.openjdk.org/jdk.git pull/14844/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14844

View PR using the GUI difftool:
$ git pr show -t 14844

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14844.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2023

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 12, 2023

⚠️ @prsadhuk This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk
Copy link

openjdk bot commented Jul 12, 2023

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jul 12, 2023
@prsadhuk
8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not s…
cc396b8 
…how the ProgressMonitorInputStream all the time
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 12, 2023

Webrevs

azvegint
azvegint approved these changes Jul 12, 2023
View reviewed changes
test/jdk/javax/swing/ProgressMonitor/ProgressTest.java
System.out.println("total " + total);
if ((total % (1024*1024)) == 0) {
try {
EventQueue.invokeAndWait(() -> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use invokeLater here for slightly faster test execution.

@openjdk
Copy link

openjdk bot commented Jul 12, 2023 •
edited
Loading

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time

Reviewed-by: azvegint, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 396 new commits pushed to the master branch:

  • 1c9691b: 8312093: Incorrect javadoc comment text
  • 37ca902: 8310233: Fix THP detection on Linux
  • 81c4e8f: 8304006: jlink should create the jimage file in the native endian for the target platform
  • e8f66bf: 8310949: RISC-V: Initialize UseUnalignedAccesses
  • 19691fa: 6361826: (reflect) provide method for mapping strings to class object for primitive types
  • c84866a: 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt
  • 0d2196f: 8311992: Test java/lang/Thread/virtual/JfrEvents::testVirtualThreadPinned failed
  • f3b96f6: 8311862: RISC-V: small improvements to shift immediate instructions
  • a63f865: 8311946: add support for libgraal specific jtreg tests
  • 167d1c1: 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC
  • ... and 386 more: https://git.openjdk.org/jdk/compare/4d4706967d44b6908406818bb135f94130f373a0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 12, 2023
@azvegint
Copy link
Member

Due to some threading issues, Progress Monitor is not shown in macos..

It's more like we didn't meet the conditions for the ProgressMonitor to appear.

https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/ProgressMonitor.html

Initially, there is no ProgressDialog. After the first millisToDecideToPopup milliseconds (default 500) the progress monitor will predict how long the operation will take. If it is longer than millisToPopup (default 2000, 2 seconds) a ProgressDialog will be popped up.

TejeshR13
TejeshR13 reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@TejeshR13 TejeshR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is not specific to MacOS, I'm able to reproduce in windows too. Fix applies to windows too.

@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 24, 2023

Going to push as commit 197981b.
Since your change was applied there have been 484 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 24, 2023
@openjdk openjdk bot closed this Jul 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 24, 2023
@openjdk
Copy link

openjdk bot commented Jul 24, 2023

@prsadhuk Pushed as commit 197981b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8311881 branch July 24, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TejeshR13 TejeshR13 TejeshR13 approved these changes

@azvegint azvegint azvegint approved these changes

Assignees
No one assigned
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prsadhuk @azvegint @TejeshR13