-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8312165: Fix typos in java.desktop Swing #14847
Conversation
update copyrights
👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into |
@turbanoff The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Keep alive. Let's wait for review a bit longer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please break such changes into smaller batches: reviewing nearly 200 files is tedious and requires lots of time. Changesets consisting of no more than 20 or 40 files would likely be reviewed quicker.
src/java.desktop/macosx/classes/com/apple/laf/AquaFileChooserUI.java
Outdated
Show resolved
Hide resolved
src/java.desktop/share/classes/com/sun/imageio/plugins/gif/GIFImageWriter.java
Outdated
Show resolved
Hide resolved
src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java
Outdated
Show resolved
Hide resolved
src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java
Outdated
Show resolved
Hide resolved
src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java
Outdated
Show resolved
Hide resolved
src/java.desktop/unix/classes/sun/print/PrintServiceLookupProvider.java
Outdated
Show resolved
Hide resolved
src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsCheckBoxUI.java
Outdated
Show resolved
Hide resolved
src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java
Outdated
Show resolved
Hide resolved
src/java.desktop/windows/classes/sun/java2d/d3d/D3DSurfaceData.java
Outdated
Show resolved
Hide resolved
src/java.desktop/windows/classes/sun/java2d/d3d/D3DSurfaceData.java
Outdated
Show resolved
Hide resolved
revert changes from non-swing parts to minimize count of files to review
apply suggestions from review
I reverted changes in non-Swing parts to reduce amount of files to review. |
I'm unsure it's the right decision, I reviewed them already. On the other hand, 100 files is a smaller chunk, someone could also take a look. Thanks for fixing typos, by the way. |
src/java.desktop/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java
Outdated
Show resolved
Hide resolved
src/java.desktop/share/classes/javax/swing/plaf/nimbus/DropShadowEffect.java
Outdated
Show resolved
Hide resolved
src/java.desktop/share/classes/javax/swing/plaf/nimbus/Effect.java
Outdated
Show resolved
Hide resolved
src/java.desktop/share/classes/javax/swing/plaf/nimbus/Effect.java
Outdated
Show resolved
Hide resolved
src/java.desktop/share/classes/javax/swing/plaf/nimbus/InnerShadowEffect.java
Outdated
Show resolved
Hide resolved
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java
Outdated
Show resolved
Hide resolved
apply suggestions from review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second “short-circuit” in JLayeredPane
at line 558 is still with the space:
even though you marked the comment as resolved.
apply suggestions from review
/contributor add @aivanov-jdk |
Ooops. Sorry for that. Somehow I forgot to commit changes in this file. |
@turbanoff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for the minor comment.
src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java
Outdated
Show resolved
Hide resolved
last fixes
@turbanoff This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 46 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Do we need a second reviewer or I can integrate? |
It's a good question. Overall, the changes are trivial: only comments are updated, some javadoc for private classes which are comments, then a couple of method names and variable names are corrected. I can't see any logic change. I would say integrate if no else looks in the next 12–24 hours. |
Did you submit a follow-up bug for those files? |
I plan to work on new PR after merge of this. |
/integrate |
Going to push as commit 89cb290.
Your commit was automatically rebased without conflicts. |
@turbanoff Pushed as commit 89cb290. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Found many typos in java.desktop by IDEA's inspection
Proofreading | Typo
Progress
Issue
Reviewers
Contributors
<aivanov@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14847/head:pull/14847
$ git checkout pull/14847
Update a local copy of the PR:
$ git checkout pull/14847
$ git pull https://git.openjdk.org/jdk.git pull/14847/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14847
View PR using the GUI difftool:
$ git pr show -t 14847
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14847.diff
Webrev
Link to Webrev Comment