Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311536: JFR TestNativeMemoryUsageEvents fails in huge pages configuration #14853

Closed
wants to merge 1 commit into from

Conversation

mgronlun
Copy link

@mgronlun mgronlun commented Jul 12, 2023

Greetings,

the test is not designed to support large pages and should disallow it if someone requests it from the outside.

Testing: the test passing -XX:+UseLargePages using --jvm-args-prepend and --jvm-args-append

Thanks
Markus


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311536: JFR TestNativeMemoryUsageEvents fails in huge pages configuration (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14853/head:pull/14853
$ git checkout pull/14853

Update a local copy of the PR:
$ git checkout pull/14853
$ git pull https://git.openjdk.org/jdk.git pull/14853/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14853

View PR using the GUI difftool:
$ git pr show -t 14853

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14853.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2023

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 12, 2023
@openjdk
Copy link

openjdk bot commented Jul 12, 2023

@mgronlun The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jul 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 12, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 12, 2023

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311536: JFR TestNativeMemoryUsageEvents fails in huge pages configuration

Reviewed-by: egahlin, mseledtsov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 119cc49: 8156889: ListKeychainStore.sh fails in some virtualized environments
  • ed9337e: 8155902: DataOuputStream should clarify that it might write primitive types as multiple byte groups
  • f82c818: 8308694: Clarify reversed() default methods' implementation requirements
  • 7304316: 8311926: java/lang/ScopedValue/StressStackOverflow.java takes 9mins in tier1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 12, 2023
@mgronlun
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

Going to push as commit 6895deb.
Since your change was applied there have been 18 commits pushed to the master branch:

  • bb5278d: 8311239: GC: Remove trailing blank lines in source files
  • 92a04e2: 8311867: StructuredTaskScope.shutdown does not interrupt newly started threads
  • f60c1f9: 8294401: Update jfr man page to include recently added features
  • 1b0dd7c: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified
  • a38a421: 8311917: MAP_FAILED definition seems to be obsolete in src/java.desktop/unix/native/common/awt/fontpath.c
  • 812dadb: 8311788: ClassLoadUnloadTest fails on AIX after JDK-8193513
  • 11a5115: 8311556: GetThreadLocalStorage not working for vthreads mounted during JVMTI attach
  • a38582e: 8311691: C2: Remove legacy code related to PostLoopMultiversioning
  • 38f7412: 8311609: [windows] Native stack printing lacks source information for dynamically loaded dlls
  • e51472e: 8309566: Migrate away from TagletWriter and TagletWriterImpl
  • ... and 8 more: https://git.openjdk.org/jdk/compare/aa7367f1ecc5da15591963e56e1435aa7b830f79...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 13, 2023
@openjdk openjdk bot closed this Jul 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@mgronlun Pushed as commit 6895deb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mgronlun
Copy link
Author

/backport jdk21

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@mgronlun the backport was successfully created on the branch mgronlun-backport-6895debf in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6895debf from the openjdk/jdk repository.

The commit being backported was authored by Markus Grönlund on 13 Jul 2023 and was reviewed by Erik Gahlin and Mikhailo Seledtsov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git mgronlun-backport-6895debf:mgronlun-backport-6895debf
$ git checkout mgronlun-backport-6895debf
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git mgronlun-backport-6895debf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants