Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311968: Clarify Three-letter time zone IDs in java.util.TimeZone #14861

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Jul 13, 2023

Please review this PR and associated CSR which links the full list of deprecated three-letter IDs in java.util.TimeZone

Although it is made apparent in TimeZone that certain 3-letter IDs are deprecated, it does not actually list them in the specification. In addition to linking the full list, it is clarified that not all 3-letter IDs are deprecated, as there are quite a few that come from the tzdb.

This change links to the full list found in ZoneId.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8311979 to be approved
  • Commit message must refer to an issue

Issues

  • JDK-8311968: Clarify Three-letter time zone IDs in java.util.TimeZone (Enhancement - P4)
  • JDK-8311979: Clarify Three-letter time zone IDs in java.util.TimeZone (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14861/head:pull/14861
$ git checkout pull/14861

Update a local copy of the PR:
$ git checkout pull/14861
$ git pull https://git.openjdk.org/jdk.git pull/14861/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14861

View PR using the GUI difftool:
$ git pr show -t 14861

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14861.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@justin-curtis-lu The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 13, 2023

Webrevs

@@ -130,7 +130,10 @@
* use is deprecated</strong> because the same abbreviation is often used
* for multiple time zones (for example, "CST" could be U.S. "Central Standard
* Time" and "China Standard Time"), and the Java platform can then only
* recognize one of them.
* recognize one of them. The full list of the deprecated IDs can be viewed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"deprecated IDs and their mappings" may read better, as SHORT_IDS is a map

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, clarified the PR and CSR

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewed the CSR too

* Zone Database (TZDB).
* recognize one of them. The full list of the deprecated IDs and their mappings
* can be viewed at {@link java.time.ZoneId#SHORT_IDS}. It should be noted that
* not all three-letter time zone IDs are deprecated, as some come from the IANA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit confusing at least to me as I did not see which SHORT_IDS were not deprecated via the link above, but perhaps I missed it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point, the intent was that there exists three-letter time zone IDs and only the deprecated ones were at SHORT_IDS. I have updated the wording to explicitly clarify this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please disregard the previous message, I talked with Naoto and all the three-letter time zone IDs (and four-letter) are deprecated regardless if they are from the JDK or TZDB, so I will readjust the wording again

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311968: Clarify Three-letter time zone IDs in java.util.TimeZone

Reviewed-by: naoto, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 0d2196f: 8311992: Test java/lang/Thread/virtual/JfrEvents::testVirtualThreadPinned failed
  • f3b96f6: 8311862: RISC-V: small improvements to shift immediate instructions
  • a63f865: 8311946: add support for libgraal specific jtreg tests
  • 167d1c1: 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC
  • 7539cc0: 8303134: JFR: Missing stack trace during chunk rotation stress
  • d1fa1a8: 8311825: Duplicate qualified enum constants not detected
  • 4676b40: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
  • bbb7ce5: 8311038: Incorrect exhaustivity computation
  • 2e12a12: 8281658: Add a security category to the java -XshowSettings option
  • 43099a8: 8311647: Memory leak in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
  • ... and 22 more: https://git.openjdk.org/jdk/compare/119cc495fc6c18a29b7484d294c31ad1d478791c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Jul 13, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 17, 2023

Going to push as commit 6a09992.
Since your change was applied there have been 48 commits pushed to the master branch:

  • 6ae152d: 8312196: ProblemList test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java
  • 295ae11: 8312195: Changes in JDK-8284493 use wrong copyright syntax
  • f975be4: 8284493: Improve computeNextExponential tail performance and accuracy
  • e737968: 8308398: Move SunEC crypto provider into java.base
  • 69a46c2: 8310157: Allow void-returning filters for MethodHandles::collectCoordinates
  • 3fb9d11: 8311172: Classfile.PREVIEW_MINOR_VERSION doesn't match that read from class files
  • afcf8e4: 8290005: com/sun/jndi/ldap/LdapCBPropertiesTest.java failling with NullPointerException
  • acf591e: 8140527: JInternalFrame has incorrect title button width
  • f6e23ae: 8310201: Reduce verbose locale output in -XshowSettings launcher option
  • a441216: 8311815: Incorrect exhaustivity computation
  • ... and 38 more: https://git.openjdk.org/jdk/compare/119cc495fc6c18a29b7484d294c31ad1d478791c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2023
@openjdk openjdk bot closed this Jul 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 17, 2023
@openjdk
Copy link

openjdk bot commented Jul 17, 2023

@justin-curtis-lu Pushed as commit 6a09992.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants