8311825: Duplicate qualified enum constants not detected

[lahodaj]

Duplicate enum constant check is missing for switches, when the qualified constants are used, so code like:

switch (...) {
     case E.A -> {}
     case E.A -> {}
}

Does not produce any errors. This patch is trying to fix this problem by adding the duplicate checks (sadly the codepaths are distinct, so the check is simply added to the various codepaths).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311825: Duplicate qualified enum constants not detected (Bug - P3)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14870/head:pull/14870
$ git checkout pull/14870

Update a local copy of the PR:
$ git checkout pull/14870
$ git pull https://git.openjdk.org/jdk.git pull/14870/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14870

View PR using the GUI difftool:
$ git pr show -t 14870

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14870.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4d95e305)

[lahodaj]

/backport jdk21

[openjdk]

@lahodaj Backport for repo openjdk/jdk21 on branch master was successfully enabled and will be performed once this pull request has been integrated. Further instructions will be provided at that time.

[vicente-romero-oracle]

looks good

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311825: Duplicate qualified enum constants not detected

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 225 new commits pushed to the master branch:

• c7c6d47: 6355567: AdobeMarkerSegment causes failure to read valid JPEG
• af7f95e: 8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out
• c710e71: 8311102: Write annotations in the classfile dumped by SA
• 61932f4: 8244289: fatal error: Possible safepoint reached by thread that does not allow it
• 8c9d091: 8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors
• b587fc5: 8312013: avoid UnixConstants.java.template warning: 'linux' is not defined on AIX
• 135f64e: 8311583: tableswitch broken by JDK-8310577
• 6895deb: 8311536: JFR TestNativeMemoryUsageEvents fails in huge pages configuration
• bb5278d: 8311239: GC: Remove trailing blank lines in source files
• 92a04e2: 8311867: StructuredTaskScope.shutdown does not interrupt newly started threads
• ... and 215 more: https://git.openjdk.org/jdk/compare/5a82fa3bb278b5b80b9ede0619f364fe13cdbede...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit d1fa1a8.
Since your change was applied there have been 229 commits pushed to the master branch:

• 4676b40: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
• bbb7ce5: 8311038: Incorrect exhaustivity computation
• 2e12a12: 8281658: Add a security category to the java -XshowSettings option
• 43099a8: 8311647: Memory leak in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
• c7c6d47: 6355567: AdobeMarkerSegment causes failure to read valid JPEG
• af7f95e: 8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out
• c710e71: 8311102: Write annotations in the classfile dumped by SA
• 61932f4: 8244289: fatal error: Possible safepoint reached by thread that does not allow it
• 8c9d091: 8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors
• b587fc5: 8312013: avoid UnixConstants.java.template warning: 'linux' is not defined on AIX
• ... and 219 more: https://git.openjdk.org/jdk/compare/5a82fa3bb278b5b80b9ede0619f364fe13cdbede...master

Your commit was automatically rebased without conflicts.

[openjdk]

Creating backport for repo openjdk/jdk21 on branch master

/backport openjdk/jdk21 master

[openjdk]

@lahodaj Pushed as commit d1fa1a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[openjdk]

@openjdk[bot] @lahodaj the backport was successfully created on the branch lahodaj-backport-d1fa1a86 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit d1fa1a86 from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 14 Jul 2023 and was reviewed by Vicente Romero.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git lahodaj-backport-d1fa1a86:lahodaj-backport-d1fa1a86
$ git checkout lahodaj-backport-d1fa1a86
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git lahodaj-backport-d1fa1a86