8313875: Use literals instead of static fields in java.util.Math: twoToTheDoubleScaleUp, twoToTheDoubleScaleDown #14875
Conversation
…woToTheDoubleScaleDown
|
👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into |
|
@turbanoff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
turbanoff
changed the title
Webrevs
|
|
@turbanoff This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 258 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
| static double twoToTheDoubleScaleUp = powerOfTwoD(512); | ||
| static double twoToTheDoubleScaleDown = powerOfTwoD(-512); | ||
| private static final double twoToTheDoubleScaleUp = powerOfTwoD(512); | ||
| private static final double twoToTheDoubleScaleDown = powerOfTwoD(-512); |
There was a problem hiding this comment.
Aren't these the literals 0x1p512 and 0x1p-512, respectively?
There was a problem hiding this comment.
Whoa. You are right.
public static void main(String[] args) {
System.out.println(twoToTheDoubleScaleUp);
System.out.println(twoToTheDoubleScaleDown);
System.out.println(0x1p512);
System.out.println(0x1p-512);
System.out.println(twoToTheDoubleScaleUp == 0x1p512);
System.out.println(twoToTheDoubleScaleDown == 0x1p-512);
}
1.3407807929942597E154
7.458340731200207E-155
1.3407807929942597E154
7.458340731200207E-155
true
true
There was a problem hiding this comment.
These static fields seem to be used just once each, so we might as well just replace the usages with the literals and get rid of the fields.
…twoToTheDoubleScaleDown completely remove the fields. Use literals instead.
turbanoff
changed the title
openjdk
bot
added
ready
turbanoff
changed the title
|
LGTM (not a Reviewer) |
|
@rgiulietti you still can approve it officially, even if you are not a reviewer. |
|
I know, but that's not an official review from the perspective of the OpenJDK, it's only a GitHub approval. |
Actually OpenJDK bot uses Github approvals as a source. For example see this PR - #13213
It's not directly related. You are right. |
|
/integrate |
|
Going to push as commit 41bdcde.
Your commit was automatically rebased without conflicts. |
|
@turbanoff Pushed as commit 41bdcde. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Couple of static fields in Math are used only once and can be replaced with literals
0x1p512/0x1p-512Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14875/head:pull/14875$ git checkout pull/14875Update a local copy of the PR:
$ git checkout pull/14875$ git pull https://git.openjdk.org/jdk.git pull/14875/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14875View PR using the GUI difftool:
$ git pr show -t 14875Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14875.diff
Webrev
Link to Webrev Comment