Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294979: test/jdk/tools/jlink 3 test classes use ASM library #14877

Closed
wants to merge 3 commits into from

Conversation

xqoasis
Copy link
Contributor

@xqoasis xqoasis commented Jul 13, 2023

Modified 3 of 3 test/jdk/tools/jlink test classes to replace com.sun.tools.classfile library.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294979: test/jdk/tools/jlink 3 test classes use ASM library (Sub-task - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14877/head:pull/14877
$ git checkout pull/14877

Update a local copy of the PR:
$ git checkout pull/14877
$ git pull https://git.openjdk.org/jdk.git pull/14877/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14877

View PR using the GUI difftool:
$ git pr show -t 14877

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14877.diff

Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jul 13, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2023

Hi @xqoasis, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user xqoasis" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@xqoasis The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 13, 2023
@asotona
Copy link
Member

asotona commented Jul 14, 2023

I would suggest to minimise footprint of the patch and do not change unrelated code.
Any unnecessary reformat can cause conflicts when merging into or from another project or when backporting.

@liach
Copy link
Member

liach commented Jul 16, 2023

I think these exports can probably be removed completely; no test code uses ASM, meaning the export was likely redundant from the very beginning.

Revert "8294979: test/jdk/tools/jlink 3 test classes use ASM library"

This reverts commit a6d7446.

8294979: test/jdk/tools/jlink 3 test classes use ASM library
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Jul 17, 2023
@asotona
Copy link
Member

asotona commented Jul 25, 2023

I think these exports can probably be removed completely; no test code uses ASM, meaning the export was likely redundant from the very beginning.

I can confirm, the tests are passing even without the exports.

@xqoasis xqoasis marked this pull request as ready for review July 27, 2023 17:23
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 27, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 27, 2023

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@xqoasis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294979: test/jdk/tools/jlink 3 test classes use ASM library

Reviewed-by: mchung, ksakata

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 227 new commits pushed to the master branch:

  • e8c325d: 8313394: Array Elements in OldObjectSample event has the incorrect description
  • d60352e: 8311006: missing @SInCE info in jdk.xml.dom
  • 4577147: 8313712: [BACKOUT] 8313632: ciEnv::dump_replay_data use fclose
  • bb3aac6: 8301606: JFileChooser file chooser details view "size" label cut off in Metal Look&Feel
  • 0f2fce7: 8313632: ciEnv::dump_replay_data use fclose
  • ab1c212: 8312909: C1 should not inline through interface calls with non-subtype receiver
  • c386091: 8312984: javac may crash on a record pattern with too few components
  • 3212b64: 8313582: Problemlist failing test on linux x86
  • bdac348: 8313602: increase timeout for jdk/classfile/CorpusTest.java
  • 58906bf: 4893524: Swing drop targets should call close() on transferred readers and streams
  • ... and 217 more: https://git.openjdk.org/jdk/compare/61932f49a58b73530e89e511874fbe2fbc343e99...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mlchung, @jyukutyo) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 27, 2023
@xqoasis
Copy link
Contributor Author

xqoasis commented Jul 31, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 31, 2023
@openjdk
Copy link

openjdk bot commented Jul 31, 2023

@xqoasis
Your change (at version 02a7b1a) is now ready to be sponsored by a Committer.

@jyukutyo
Copy link
Contributor

jyukutyo commented Aug 4, 2023

I'll sponsor you. I've checked those tests passed.

@jyukutyo
Copy link
Contributor

jyukutyo commented Aug 4, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 4, 2023

Going to push as commit 10a2605.
Since your change was applied there have been 227 commits pushed to the master branch:

  • e8c325d: 8313394: Array Elements in OldObjectSample event has the incorrect description
  • d60352e: 8311006: missing @SInCE info in jdk.xml.dom
  • 4577147: 8313712: [BACKOUT] 8313632: ciEnv::dump_replay_data use fclose
  • bb3aac6: 8301606: JFileChooser file chooser details view "size" label cut off in Metal Look&Feel
  • 0f2fce7: 8313632: ciEnv::dump_replay_data use fclose
  • ab1c212: 8312909: C1 should not inline through interface calls with non-subtype receiver
  • c386091: 8312984: javac may crash on a record pattern with too few components
  • 3212b64: 8313582: Problemlist failing test on linux x86
  • bdac348: 8313602: increase timeout for jdk/classfile/CorpusTest.java
  • 58906bf: 4893524: Swing drop targets should call close() on transferred readers and streams
  • ... and 217 more: https://git.openjdk.org/jdk/compare/61932f49a58b73530e89e511874fbe2fbc343e99...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 4, 2023
@openjdk openjdk bot closed this Aug 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@jyukutyo @xqoasis Pushed as commit 10a2605.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants