8312077: Fix signed integer overflow, final part

[dean-long]

This is hopefully the last set of integer overflow fixes for hotspot. Some of the counters I changed to unsigned are updated in platform-specific code, so I could use some help testing on arm, ppc, riscv, and s390.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312077: Fix signed integer overflow, final part (Sub-task - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 7ed08326
• Amit Kumar (@offamitkumar - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14883/head:pull/14883
$ git checkout pull/14883

Update a local copy of the PR:
$ git checkout pull/14883
$ git pull https://git.openjdk.org/jdk.git pull/14883/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14883

View PR using the GUI difftool:
$ git pr show -t 14883

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14883.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dean-long The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (1153ce96)
• 05: Full - Incremental (0c14f96c)
• 04: Full - Incremental (7ed08326)
• 03: Full - Incremental (90cde0be)
• 02: Full - Incremental (ace9c66a)
• 01: Full - Incremental (7cc45534)
• 00: Full (75e87462)

[vnkozlov]

Good.

[openjdk]

@dean-long This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312077: Fix signed integer overflow, final part

Reviewed-by: kvn, amitkumar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 19691fa: 6361826: (reflect) provide method for mapping strings to class object for primitive types
• c84866a: 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt
• 0d2196f: 8311992: Test java/lang/Thread/virtual/JfrEvents::testVirtualThreadPinned failed
• f3b96f6: 8311862: RISC-V: small improvements to shift immediate instructions
• a63f865: 8311946: add support for libgraal specific jtreg tests
• 167d1c1: 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC
• 7539cc0: 8303134: JFR: Missing stack trace during chunk rotation stress
• d1fa1a8: 8311825: Duplicate qualified enum constants not detected
• 4676b40: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
• bbb7ce5: 8311038: Incorrect exhaustivity computation
• ... and 2 more: https://git.openjdk.org/jdk/compare/c7c6d47a07100f6c81af6cfad301ec1bda77adf7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dean-long]

My tier10 testing is still running, so I may add a few more fixes to this. I just added one in c1_Compilation.cpp.

[dean-long]

@offamitkumar @TheRealMDoerr @RealFYang @bulasevich please check that I haven't broken the s390/ppc/riscv/arm32 ports.

[offamitkumar]

I couldn't see any s390-specific code change here. Still tested fastdebug & release builds.

Looks Good.

[RealFYang]

@offamitkumar @TheRealMDoerr @RealFYang @bulasevich please check that I haven't broken the s390/ppc/riscv/arm32 ports.

FYI: Performed tier1, tier2 and tier3 tests on linux-riscv64 platform. Result is clean.

[dean-long]

Thanks Vladimir, Andrew, @RealFYang and @offamitkumar.

[bulasevich]

Hi, the change looks good for me. ARM32 tests are OK.

[dean-long]

Thanks @bulasevich.

[dean-long]

I'm still waiting on some tier10 tests that take 7 days to complete.

[dean-long]

/integrate

[openjdk]

Going to push as commit d0761c1.
Since your change was applied there have been 114 commits pushed to the master branch:

• 2bdfa83: 8262742: (fs) Add Path::resolve with varargs string
• 8008e27: 8308903: Print detailed info for Java objects in -Xlog:cds+map
• d8f2e9a: 8310530: PipedOutputStream.flush() accesses sink racily
• fac9f88: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files
• d5c6b0d: 8311261: [AIX] TestAlwaysPreTouchStacks.java fails due to java.lang.RuntimeException: Did not find expected NMT output
• d1cc278: 8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [i4] but found [I4]
• 3caf64e: 8309238: jdk/jfr/tool/TestView.java failed with "exitValue = 134"
• 298dda4: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed
• 7dd4799: 8311847: Fix -Wconversion for assembler.hpp emit_int8,16 callers
• 197981b: 8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time
• ... and 104 more: https://git.openjdk.org/jdk/compare/c7c6d47a07100f6c81af6cfad301ec1bda77adf7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dean-long Pushed as commit d0761c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.